search

EngineerBetter / control-tower

Deploy and operate Concourse CI in a single command
https://www.engineerbetter.com
Apache License 2.0
121 stars 38 forks source link

Enable x-frame options #67

Open ostenbom opened 4 years ago

ostenbom commented 4 years ago

Concourse supports configuring the x-frame options of the web worker. Docs link here.

We would love to be able to embed our concourse deployment into our other dashboards. Would it be possible to add this option to control tower?

I think that this could be done very similarly to how the "enable global resources" was added.

Happy to contribute with a pull request if applicable.

Thanks!

irbekrm commented 4 years ago

Hi @ostenbom ,

Thanks for the suggestion, we could implement this if it is useful.

Thanks for offering to contribute! It does look like it could be quite similar to how 'enable global resources' was added, as you say. The commit you linked adds a CLI flag for the new property to the Control Tower codebase. Additionally, Control Tower deploys Concourse as a Bosh release and the Bosh manifest for the deployment is not a part of this repository. Configuring x-frame options for Bosh deployed Concourse would probably involve adding this property to the deployment manifest. We have a process which involves pushing the deployment manifest to a private repo, testing it and then publishing a new release of the manifest to the public control-tower-ops repo. If you were to contribute, you could probably manually add this property to the manifest in control-tower-ops (See docs about Control Tower development) for local testing. Then, when it's ready, we could update the original manifest file. Let us know what you think, I will in any case add a story to our backlog for this.

ostenbom commented 4 years ago

Thanks for pointing me in the right direction @irbekrm! I have opened a pull request with an initial implementation where we can continue the discussion.