search

EngoEngine / ecs

A Go-implementation of the Entity-Component-System paradigm
MIT License
298 stars 43 forks source link

ecs: Update documentation and fix golint issues. #20

Closed mewmew closed 8 years ago

mewmew commented 8 years ago 
u@x1 ~/g/s/e/ecs> golint .
entity.go:11:2: don't use underscores in Go names; var id_incr should be idIncr
entity_test.go:53:1: receiver name sys should be consistent with previous receiver name m for MySystemOneTwo
mewmew commented 8 years ago

What with merging just one second.

mewmew commented 8 years ago

Ok, there we go. Now this PR is ready for review.

otraore commented 8 years ago

This PR has died down, my apologies for forgetting about it. Would you mind bringing it back up with master so I can give it a review?

mewmew commented 8 years ago

This PR has died down, my apologies for forgetting about it. Would you mind bringing it back up with master so I can give it a review?

Hi @otraore! Now the doc branch has been brought up to date. Cheers /u

otraore commented 8 years ago

LGTM.