tmx: fix the tmx/tsx loading

EngoEngine / engo

Engo is an open-source 2D game engine written in Go.

https://engoengine.github.io

MIT License

1.73k stars 137 forks source link

tmx: fix the tmx/tsx loading #768

Closed faide closed 3 years ago

faide commented 3 years ago

Hello,

this little patch fixes an issue when trying to load tmx files that reference tsx files

it tries to be as unobtrusive as possible by defining a new interface and only using it if the given file loader supports this new interface.

Cheers, Florent

eth0net commented 3 years ago

Oo nice! This will help me out for sure, I meant to look at this but ended up embedding the TSX contents in the TMX 🤷🏼‍♀️

Look forward to trying this out as a better solution though!

faide commented 3 years ago

Hello project members,

I see some qa tests failing but they are on the audio system I did not touch. Does anyone know what is going on here ?

faide commented 3 years ago

I fixed the tests locally lets see if all passes

coveralls commented 3 years ago

Coverage increased (+0.01%) to 40.936% when pulling ee419c2abfdcdcb0ef5ee01c1d6ba276979bb486 on faide:master into 32f0ebede7800d138256ea5b1f13fb0b182ae6a2 on EngoEngine:master.

Noofbiz commented 3 years ago

Looks good to me. The audio stuff is just stuff I haven't figured out how to test well yet. It doesn't affect whether tests pass or fail. Thanks for the contribution!