Role Basis Changer (port from TOH-Y)

[Ultradragon005]

It's F#cking awesome

• Change role midgame
• Revive Players
• STABLE INVISIBILITY FOR EVERYONE, I think
• Completely fix blackscreen

TaskList:

• [x] Rigorously test it for any bugs/issues

• [x] Make A proper RPCsetrole extension method for making desync or switching player to imp team.

• [x] Completely fix blackscreen, temporarily remove resetcam (cuz innerdick might remove canovverride 😭).

• [x] Desync players can become ghost roles again 😼

• [x] Make it so desync crewmates get assigned the impostor role after intro screen to make it much less confusing.

• Later, Make phantomrpc usable for everyone, by use rpcsetrole instead of vent desync. (I think this should theoretically be possible, but I would need to test this later to make sure)

[Ultradragon005]

~hmm okay, some very funky stuff happens when a desync player is introduced, will have to fix it~ OKAY THAT WAS SIMPLE LOL

[HyperAtill]

It's F#cking awesome

• Change role midgame
• Revive Players
• STABLE INVISIBILITY FOR EVERYONE
• Completely fix blackscreen

WHAT? MAN ARE YOU JOKING?!

[Ultradragon005]

WHAT? MAN ARE YOU JOKING?!

https://i.gyazo.com/5927eec60cac02271fe252187e93d920.mp4 nah

[HyperAtill]

WHAT? MAN ARE YOU JOKING?!

https://i.gyazo.com/5927eec60cac02271fe252187e93d920.mp4 nah

This is fantastic!!

[Tommy-XL]

I hope innersloth doesn't remove canOverride

[Tommy-XL]

I think it would be better to use SetDisconnectedMessage the abovesender.Value.EndMessage(); and under because the message is sent multiple times to the same player

[Ultradragon005]

~oh shit I didn't even notice I did that 💀~

NVM it was supposed to be like that

[Tommy-XL]

I think we need to do a similar check for changing a role type

[Tommy-XL]

Although, we don't use it for roles yet, so we can leave it as is

[Ultradragon005]

I think we need to do a similar check for changing a role type

yeah, something like that

[Ultradragon005]

by "Rigoroulsy test" I'll probably jsut going to do 1-2 rounds with it 💀 and seeing if someone blackscreen or not. in my tests it did not

[Ultradragon005]

dammit, DY neutrals still cause me issues, Ig Imma just rework the entire system

[Tommy-XL]

I think we need to temporarily abandon changing the intro by changing roles since it is not stable, the main thing now is to make code that changes the role basics stably and also revives players and ect.

[Ultradragon005]

I think we need to temporarily abandon changing the intro by changing roles since it is not stable, the main thing now is to make code that changes the role basics stably and also revives players and ect.

nah, the current system I did is just trash lmao 😂 it disconnects it 255 times instead of 15.

But, if after I fixed it, and it still unstable, then sure.

[Tommy-XL]

I will also try to optimize the display of settings in the logs today or tomorrow because because of it modded players have a delay in displaying the intro than vanilla

[Ultradragon005]

I think the new system is done, I jsut have to double-check everything.

Also this system will allow, to for example have a serial killer and sidekick see each-other on the intro screen.

[Ultradragon005]

seems good, u can test the crewmates late-assign of basis now. It should be working ALOT more stably. (also host dosen't get blackout now LOL)

[Ultradragon005]

probably done by tomorrow. All that is left for me to do is test it to find unexpected bugs if any.

[Ultradragon005]

goddamit, everytime I find a blackscreen fix, the fix suddenly stops working after I did 5 more tests with the exact same fckn fix 😭

well, that's the only thing left at least.

[Ultradragon005]

wait, I still forgot rpcset abilit cooldown on revive 💀 I'll do that now so I don't forget

[Ultradragon005]

time to copy toh-y code line by line and see if that works . I geniuenly don't see what else could toh-y fixed except for desync imp assign again which I tried tho

[Ultradragon005]

nvm, it's onyl for afterdeathplayers, that toh-y uses resetcams

[Ultradragon005]

ok...... toh-y fix works. but I have to fix some thigns abt it

[Ultradragon005]

it would seem like everything is okay now. But, all Guardian Angels now have to be desynced and use resetplayercam. But in exchange, litteraly everyone else dosen't blackscreen.

I'm gonna run last few test tomorrow morning to make sure everything is 100% set. Ofcourse, there might be stuff I overlooked but this is why we have dev builds.

[Ultradragon005]

WE ARE ABSOLUTELY BALLING OUT OF CONTROL 🗣💯💯🔥

[redphantom1000]

i'm not a contributor myself but just wanted to give yall a big thanks for fixing the black screen problems