search

Enigma-Game / Enigma

Enigma is a puzzle game inspired by Oxyd on the Atari ST and Rock'n'Roll on the Amiga. The object of the game is to find uncover pairs of identically colored Oxyd stones. Simple? Yes. Easy? Certainly not! Hidden traps, vast mazes, laser beams, and, most of all, countless hairy puzzles usually block your direct way to the Oxyd stones …
GNU General Public License v2.0
134 stars 38 forks source link

ScoreManager not using rel2 #53

Closed double-a closed 2 years ago

double-a commented 3 years ago

Compiler warning pointed to rel2 not used in lev/ScoreManager.cc line 624. Removing it would make the whole section unused thus I guess either I don't get the logic or the underlying issue is in line 627 which should use rel2 (insted of rel1), i.e.

return (rel2 >= TRUSTED_RELEASE) ? score2 : SCORE_UNSOLVED;

alochmann commented 2 years ago

I am not very familiar with this part of the code. But I agree with your assessment, this should probably be rel2 instead of rel1.

Please keep this issue open, I will fix this later, when 1.31 approachs.

alochmann commented 2 years ago

I took a dive into Ronald's code, and yes, you were right, that was a typo. Thanks!