Enigmatic-Smile / serverless-plugin-optimize

⛔️ DEPRECATED ⛔️ Bundle with Browserify, transpile and minify with Babel automatically to your NodeJS runtime compatible JavaScript
https://www.npmjs.com/package/serverless-plugin-optimize
MIT License
130 stars 53 forks source link

Feedback on other Serverless setups #2

Open goncaloneves opened 7 years ago

goncaloneves commented 7 years ago

We are using this plugin in production but would be useful to get some information how does it handle other setups.

Cheers! 😃

ro-savage commented 6 years ago

We've been using it for a couple months as we ready for production launch. Only thing that caught us out was #32. Beyond that it was easy to setup and everything just worked.

darbio commented 6 years ago

I've just converted a project to use it (25 functions) and it's sped up deployment a lot. I've had some issues with using npm projects that don't play nicely with (I suspect) browserify (such as nodemailer) which I'm still working through.

Errors such as:

Unable to import module '_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler': Error
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:554)
at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745
at Object.467.semver (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:86189:18)
at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:694)
at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745
at Object.1190.chalk (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:235973:15)
at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:694)
at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745
at Object.1188../css (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:235686:14)
at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:694)
at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745
at Object.1189../css (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:235965:15)

Currently working through these to see what the issue is.

bwisitero commented 6 years ago

@darbio did u get to resolve this issue?

darbio commented 6 years ago

@bwistero yes and no.. See #54 - I removed the offending packages and replaced them with ones that could be webpacked. We're using it in production now with no issues.