search

EnigmaticaModpacks / Enigmatica10

The official repository and issue-tracker for Enigmatica 10 for Minecraft 1.21
2 stars 7 forks source link

Recurring freezing with journeymap #20

Closed SupaJordy closed 1 month ago

SupaJordy commented 2 months ago

Modpack Version

1.3.0

Describe your issue.

I've been happily playing e10 but when updating to 1.3.0 the game started freezing every 4 seconds or so. I downloaded a new instance of e10 1.2.0 and created a new world. Again, worked without issue but when I update to 1.3.0 I get the freezing every few seconds. I created a spark profile https://spark.lucko.me/4kEqk7gmBH ) and the handy folks in the Enigmatica support channel suggested that JourneyMap might be the problem. After disabling JourneyMap, I no longer have the issue.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

jordacus

NielsPilgaard commented 2 months ago

Thanks for the report.

I can't locate the issue through the profile, @Darkere can you?

Darkere commented 2 months ago

Journeymap is throwing an error loading textures which is taking a long time. There could be something in the log showing which entity or block is causing that?

NielsPilgaard commented 2 months ago

@SupaJordy could you provide your latest.log please?

NielsPilgaard commented 2 months ago

I downloaded a fresh client and had the same behaviour. My log had rendering issues that came from Simple Discord RPC. @SupaJordy please try removing the mod Simple Discord RPC and see if that resolves the issue.

NielsPilgaard commented 2 months ago

Oh nvm, I was encountering this: https://github.com/hypherionmc/simple-rpc-public/issues/88

We still need that log of yours :D

SupaJordy commented 2 months ago

@NielsPilgaard Do you want it even though it's not happening since I disabled journeymap? Or do I need to get the log while it's happening?

I have since started a new world without journeymap.

NielsPilgaard commented 2 months ago

We would need the log from while it's happening I'm afraid 😅

SupaJordy commented 2 months ago

Weird thing, I downloaded a new instance of 1.2.0 and instantly updated it to 1.3.0, then logged in and created a new world. I didn't get the freezing issue.

I then downloaded another 1.2.0 instance, created a new world and then updated to 1.3.0. In this instance the freezing issue happens.

Here is the latest.log for the world with the issue.

latest.log

NielsPilgaard commented 2 months ago

Could you provide a log where the issue is not present? I'd like to know if this line appears there as well: [05Jul2024 13:53:14.825] [Render thread/WARN] [oshi.util.platform.windows.WmiQueryHandler/]: COM exception: Invalid Query: SELECT PERCENTUSAGE FROM Win32_PerfRawData_PerfOS_PagingFile

SupaJordy commented 2 months ago

Sure.

This is the log from the world where I have disabled journeymap and am playing without issue: latest.log

And this is the log from the world I created on 1.3.0 instead of updating. I've only run about on this world long enough for me to be satisfied that the issue wasn't happening. latest.log

NielsPilgaard commented 2 months ago

Yay it doesn't \o/ I'll try to relay to Journeymap

NielsPilgaard commented 2 months ago

They might want your journeymap/journeymap.log log aswell 😅

SupaJordy commented 2 months ago

Sure thing. This is from the instance with the issue. journeymap.log

NielsPilgaard commented 2 months ago

That was quick, thanks! That log has much more info 😅

NielsPilgaard commented 2 months ago

Could you try with the latest Journeymap please? beta.14 :)

SupaJordy commented 2 months ago

I removed journeymap 13 jar from the mod folder and added the neoforge journeymap 14 jar: image

Launched e10 and loaded the world but I still get the freezing every 3-5 seconds on this version.

Spark profile: https://spark.lucko.me/EQktnoI5IX latest.log: latest.log journeymap log: journeymap.log

spark
spark is a performance profiler for Minecraft clients, servers, and proxies.
NielsPilgaard commented 2 months ago

Perfect, thank you 😊

mysticdrew commented 2 months ago

Have you added any mods other than what's in the pack, and is anyone else having this issue?

I'm the journeymap dev, this issue is really odd.

NielsPilgaard commented 2 months ago

I have similar entries in my log, but no lag:

https://gist.github.com/NielsPilgaard/00055879ff6ce1c8b117e300cbce05fc

The log appeared after I encountered creepers from the Creeper Overhaul mod.

Gist
gist:00055879ff6ce1c8b117e300cbce05fc
GitHub Gist: instantly share code, notes, and snippets.
mysticdrew commented 2 months ago

Oh interesting, thanks. I'll have to look into that mod.

mysticdrew commented 2 months ago

jm.zip I had had to add this to a zip so i could upload it to github.

Anyways, can you give that a try please? Also after trying it, can you provide your journeymap.log? I added some extra logging to see what is going on and a potential fix.

SupaJordy commented 2 months ago

@mysticdrew Other than switching to JourneyMap 14 beta, this is just a fresh install of e10.

I'll use that file and report back.

SupaJordy commented 2 months ago

I removed the JourneyMap 14 beta jar and replaced it with the one in your zip file. Oddly, it seems to work without the lagging issue.

Journeymap log: journeymap.log

mysticdrew commented 2 months ago

Thanks, the logs don't have much. Can you play for a while and uploada new log later please? I need to see what entities are causing it.

SupaJordy commented 2 months ago

No problem. Not sure when I will get to do this but will upload when I can. Just to point out, the issue DIDN'T seem to be happening with the jar in that zip file.

mysticdrew commented 2 months ago

I understand that it's not happening. Because I kinda fixed it half way. But you won't get entity icons for some entities.

Sorry, github does not work well on mobile. So, all I did was add a null check to the icon check, but that only half fixes it. We generate icons dynamically from the models of the entities. this is new in v6, but not all mod added entities will work, so with the log file it will tell me what entities the textures are not correct that caused that issue. So we can look at it to see if we can address it.

Oh I do see this now that I look at the log file on my pc. Icon missing for entity creeperoverhaul:textures/entity/plains/plains_creeper.png

SupaJordy commented 2 months ago

@mysticdrew Ran around for 15 minutes or so.

journeymap.log

hypherionmc commented 2 months ago

Oh nvm, I was encountering this: hypherionmc/simple-rpc-public#88

We still need that log of yours :D

We're pushing out an update for craterlib in the next day or two to address this issue. We finally found the cause of it, and it spans back several versions of Simple RPC. As far as we are aware, it only affects DIRECT connections and lan connections.

NielsPilgaard commented 2 months ago

We're pushing out an update for craterlib in the next day or two to address this issue. We finally found the cause of it, and it spans back several versions of Simple RPC. As far as we are aware, it only affects DIRECT connections and lan connections.

I saw, thank you 👍