EnigmaticaModpacks / Enigmatica10

The official repository and issue-tracker for Enigmatica 10 for Minecraft 1.21
3 stars 7 forks source link

Occutlism crushed ore have no tags #42

Closed calog3no closed 2 months ago

calog3no commented 2 months ago

Modpack Version

1.5.0

Describe your issue.

When the foliot crusher crushes ores they drop Empty tag c:dusts. EMI/JEI show the recipe results as mekanism crushed ores for some and modern industrialization for some also. 2024-07-21_05 02 16

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

calog3no

NielsPilgaard commented 2 months ago

Thanks for the report

@klikli-dev Got a bug for you 😊

MuteTiefling commented 2 months ago

Can confirm this one too. My fission reactor ran out of fuel and I found my uranium crushing Marids sitting around in a pile of barriers :D

MuteTiefling commented 2 months ago

Was working fine in occultism-1.21-neoforge-1.136.4 with neo 21.0.95 as near as I can remember. Pack is now on occultism-1.21-neoforge-1.136.5 with neo 21.0.113

calog3no commented 2 months ago

So it seems any thing that the occultism crusher crushes turns into an empty tag result. Tested obsidian and demon fruit.

2024-07-21_16 05 44

flece commented 2 months ago

diamond Ore is working fine :)

MuteTiefling commented 2 months ago

There's something else going on here, I think. I've downgraded occultism all the way to 1.134.6 and it has not started working. It was working fine for me in dev though at some point as I set up a whole mekanism fission reactor based on their crushing... gonna keep digging

MuteTiefling commented 2 months ago

ok, yeah it works fine as soon as I remove our recipe additions. swapping them over to a tag output appears to fix the issue

MuteTiefling commented 2 months ago

hrm, spoke too soon... issue is back after a restart.

MuteTiefling commented 2 months ago

Yeah, just doing a /reload fixes it. So there's something goofy with tags again >.< I've removed all of our tag scripts from Kube and still have the issue on first launch until I /reload

MuteTiefling commented 2 months ago

They also work fine on first launch with KubeJS disabled >.< so it's not a script thing, but likely something with KubeJS itself

MuteTiefling commented 2 months ago

OK. Seems to be the tag based stonecutting script I implemented to add chiseled/chipped recipes to the stonecutter. Removing that has fixed this.

calog3no commented 2 months ago

just updated my develop repo and crushing seems to be fixed!!!

MuteTiefling commented 2 months ago

Don't celebrate just yet :D It broke on me again.

It does seem to be some interplay between occultism and kubejs, specifically something with one or more of our scripts since it doesn't happen without the scripts... I've narrowed things down some more but it's still not quite clear yet.

MuteTiefling commented 2 months ago

I think I've narrowed it down to this script.

https://github.com/EnigmaticaModpacks/Enigmatica10/blob/master/kubejs/server_scripts/recipes/enigmatica/replace_input.js

Not sure how or why, but any of those replaceInputs breaks the crusher

GitHub
Enigmatica10/kubejs/server_scripts/recipes/enigmatica/replace_input.js at master · EnigmaticaModpacks/Enigmatica10
The official repository and issue-tracker for Enigmatica 10 for Minecraft 1.21 - EnigmaticaModpacks/Enigmatica10
klikli-dev commented 2 months ago

I cannot promise that it is related, but the kubejs people said that the stability of occultism<->kubejs interactions will be improved by providing recipe schemas - I am trying to do that in the next few days. The occultism-kubejs mod will have them, it just takes a while as I need to add some custom code to handle e.g. the crusher recipe results that can use tags.

MuteTiefling commented 2 months ago

Alright, thanks for looking into it @klikli-dev. Worst case, I seem to be able to fix it with Kube by replacing the output with our own preferred item. If adding the schema doesn't fix it, then I can just move ahead with this.

MuteTiefling commented 2 months ago

Klikli has updated https://www.curseforge.com/minecraft/mc-mods/occultism-kubejs and I can confirm that this does in fact fix the issue :D So I'll go ahead and revert my workaround and we can proceed with this next update. <3 @klikli-dev

CurseForge
Occultism KubeJS
KubeJS plugin for Occultism. 3.1M Downloads | Mods