search

EnigmaticaModpacks / Enigmatica2

The official repository and issue-tracker for Enigmatica 2
https://www.curseforge.com/minecraft/modpacks/enigmatica2
32 stars 22 forks source link

Environmental Tech Solar Rounding Error #680

Closed nyanlathotep closed 3 years ago

nyanlathotep commented 4 years ago

Modpack version 1.77

Issue Environmental Tech Solars have no exponential growth on tier 2, because the mod appears to be improperly flooring its exponential factor before using it. Higher tiers are affected, but not by as much. The issue is that the exponent is being floored before being applied, so the actual per-cell formula appears to be:

floor(baseProduction floor(exponent^(tier - 1)) min(maxEfficiency, averageEfficiency))

On integer exponents, like default, it's fine, but exponents below 2 make this particularly problematic. With the pack's setting of 1.8, tier 2 arrays have 80% less output than expected, and the higher tiers have something like 5-15% less. The real factors are 1, 3, 5, 10, and 18 rather than 1.8, 3.2, 5.8, 10.5, and 18.9.

NielsPilgaard commented 4 years ago

Oh that's the reason the tier 2 is off!

Would you mind re-posting this on the ET issue tracker? It sounds like you would be better at answering any questions about it than I would ^^

https://github.com/ValkyrieofNight/EnvironmentalTech/issues

GitHub
ValkyrieofNight/EnvironmentalTech
This repo is for issues and localizations. Contribute to ValkyrieofNight/EnvironmentalTech development by creating an account on GitHub.
nyanlathotep commented 4 years ago

Done. ET issue is here.