search

EnigmaticaModpacks / Enigmatica2Expert

The official repository and issue-tracker for the modpack Enigmatica 2: Expert for Minecraft 1.12.2
https://www.curseforge.com/minecraft/modpacks/enigmatica2expert
Other
142 stars 129 forks source link

Villager Market client crash upon interacting #1156

Closed Frikkle closed 5 years ago

Frikkle commented 5 years ago

Modpack version 1.62

Can the issue be reproduced? Yes

Logs Here

Issue From a loot box I received a Villager Market; which I placed in a village and upon interacting with the market, the client crashed with attached log message. It crashed upon opening the block; it shows the interface for a few seconds (probably whilst loading the recipes that should be shown) before crashing.

Frikkle commented 5 years ago

Some additional information about villagers around:

Maybe it's the case that one of these villager classes is implemented in such a way that they share their recipes between multiple instances of that village class. Whilst iterating through them something might break. Not sure though since I'm not too familiar with the implementation of the villagers.

Frikkle commented 5 years ago

Never mind; this might have been a timing issue or random one-off. The second time when interacting with the item (after a reload) everything works as expected.

However if someone would want to try reproduce this; that would be great.

MaxNeedsSnacks commented 5 years ago

This may actually not be a one-off, I remember crashing on an older version under pretty much the exact same circumstances

Frikkle commented 5 years ago

Hmm, in that case, here's exactly what I did:

  1. Place the market down in my own base (with no villagers around). I did have a Cooking For Blockheads market near there; not sure if related. It's recipes didn't show up in the Villager Market.
  2. Picked up the Villager Market and place it in the village.
  3. Interacted with the Villager Market.

I'll try these steps again and see what happens.

Frikkle commented 5 years ago

While doing some trading and interacting a few times with the block (without picking it up and placing it down again) it crashed again. So there's definitely something fishy here...

Frikkle commented 5 years ago

Additionally I notice that when interacting with the market, it does not always correctly notice available items in your inventory. You then first have to put them in your hand so it will know the items are available for trade.

NielsPilgaard commented 5 years ago

This is the second time I've heard about this issue, did any of the villagers trade Iron Ingots?

Frikkle commented 5 years ago

Yes, Iron Ingots are provided.

Here's a list of all the traded items provide by the villagers; (3x) denotes it's offered by three villagers:

valuial commented 5 years ago

I do remember having that crash back in 1.59a. Also placed the market in my base first (blockheads market also present), broke it and placed it in the village. First time accessing it there I got the crash. Reloaded the world and it was fine since.

I'm not sure if it is related, but before the crash, MineCraft was running (in the Title screen, I believe) for several hours (didn't want to wait for all the mods to load when coming home).

NielsPilgaard commented 5 years ago

I was not able to reproduce this issue by any means.