EnigmaticaModpacks / Enigmatica2Expert

The official repository and issue-tracker for the modpack Enigmatica 2: Expert for Minecraft 1.12.2
https://www.curseforge.com/minecraft/modpacks/enigmatica2expert
Other
141 stars 125 forks source link

Small QoL Updates to Fluid Containers #2130

Open Quikswitch opened 1 year ago

Quikswitch commented 1 year ago

Describe your suggestion

  1. Add a recipe for any fluid container (say, IC2 Universal Cells) that returns an empty version. E.g. I have a cell full of Compressed Air (IC2), and want an empty cell. I can discard the fluid completely by putting it in the crafting grid by itself. Ideally, this would include the Ender Bucket, Reinforced Ender Bucket, all tanks, and similar storage devices. If that's too much to code, the most commonly used containers should probably be prioritized.

  2. Remove all "Bucket of *", Universal Fluid Cell (containing a fluid), Foresty Tin, Wax, and Refactory Wax capsules, Florb and OpenBlocks Tank (containing a fluid) from JEI.

  3. If possible, remove OpenBlocks Tank from "Aspect from ItemStack" tabs for Thaumcraft's JEI addon

  4. If possible, add fluids themselves to JEI, with the associated recipes.

  5. If needed to accomplish these suggestions, switch to Had Enough Items.

These changes are implemented in modern versions of Nomifactory, which uses HEI instead of JEI. I am not sure how viable all of these suggestions are to implement in JEI.

Why would you like this added/changed?

  1. Emptying fluid containers is a serious hassle, typically requiring manually right clicking on trash cans. Since trash cans can be crafted easily enough, it's not a feature that appears to be intended to be gated, and so the ability to do it on the fly would be a great help.

  2. Together, these recipes are ~6,000 items in JEI. That's many pages, and all of the recipes are basically useless. It's a lot of clutter, and kind of annoying to work around.

  3. For similar reasons to the above, searching for items by aspect in JEI for Vitreus, Tenebrae, Ignis, and Terra has the bottom half of results being taken up by the OpenBlocks Tank, with no consideration for the actual liquid inside. It's a lot of clutter to sort though, and would be better off removed if possible. Removing the aspects on the OpenBlocks Tank may work if that's a possibility with very little lost in the play experience.

  4. While I am not sure of the viability of this suggestion, if all "Bucket of " (and similar) items are removed from the current version (as of writing, 1.90e), there will not be any comprehensive list of fluids in JEI. If those fluids (sans item forms) were available for viewing, the list would exist, and still be independent of the item container. If this suggestion isn't viable, keeping specifically "Bucket of " items would suffice as a list, and would be most appropriate since the bucket is vanilla.

  5. I am not sure of the exact differences between HEI and JEI (I've done some personal research, but have come up mostly empty handed as to specifics). HEI does apparently handle fluids differently, and I believe it works with JEI addons. It may or may not be a "drag and drop" replacement. I am not sure. I am also not sure about its development situation, or if that would matter to e2e.

(PS: Thanks for making a fantastic modpack!)

NielsPilgaard commented 1 year ago

Thanks for the great suggestion!

I believe 1-3 are possible, and would be nice addtions. What do you think @Discomanco, 1.91?

I don't think 4) is possible, and I'm not willing to do 5) to make it happen 😄 too many risks associated with swapping out mods.

Discomanco commented 1 year ago

Not entirely sold on hiding every bucket, but apart from that 1-3 sounds good. For 4, yeah I don't believe we have to power to order JEI in any way. And agreed, 5 is not going to happen.

But this could make a candidate for 1.91 yes

NielsPilgaard commented 1 year ago

Ah yes, the buckets should remain, agreed.

MorganSimic commented 1 year ago

Iirc we did had the fluids and a lot more stuff hidden and then people complained, so they got unhidden in some version, i faintly remember. But personally i like the hidden stuff more. We already also have a lot of tank clearing recipes and those are not quite as easy as you might imagine. But it's certainly worth looking into it.