EnigmaticaModpacks / Enigmatica2Expert

The official repository and issue-tracker for the modpack Enigmatica 2: Expert for Minecraft 1.12.2
https://www.curseforge.com/minecraft/modpacks/enigmatica2expert
Other
140 stars 128 forks source link

I think I've done this right? Re-enable the gas intake #2185

Closed HeatherComputer closed 5 months ago

HeatherComputer commented 5 months ago

I've tested ingame, all seems good, but the amount of stuff that's changed in minecraftinstance.json simply for adding one mod has me concerned - is this normal?

Kanzaji commented 5 months ago

the amount of stuff that's changed in minecraftinstance.json simply for adding one mod has me concerned - is this normal?

From what I know that's normal, CF being CF, and it rewrites a ton of stuff in the file 😅 Tho the best option is to just leave the mod addition to the Disco/Niller when they merge the PR, like I always do for example 😄

Discomanco commented 5 months ago

Yeah, adding mods through PRs is basically impossible. Otherwise the rest is correct - I just need to get back to it eventually :'V

HeatherComputer commented 5 months ago

Interesting. Would you want me to revert that minecraftinstance.json change?

Discomanco commented 5 months ago

Yeah might as well, as it doesn't really do anything

HeatherComputer commented 5 months ago

That should now be done

HeatherComputer commented 5 months ago

Hehe, just don't forget to add the mod - without it we'd be back at having the dupe and an enabled gas valve