search

EnigmaticaModpacks / Enigmatica2Expert

The official repository and issue-tracker for the modpack Enigmatica 2: Expert for Minecraft 1.12.2
https://www.curseforge.com/minecraft/modpacks/enigmatica2expert
Other
141 stars 129 forks source link

Advanced Turtle: Unable to equip (or craft) with tools #655

Closed Meissnerim closed 5 years ago

Meissnerim commented 5 years ago

Issue Description I've got a Advanced Turtle from one of the Loot boxes. I want to use it as a Advanced Mining Turtle oder Advanced Melee Turtle. I can't equip tools (pickaxe or sword) nor can I craft the Advanced turtle with tools.

Modpack version Enigmatica2Expert 1.51 which contains CCTweaked cc-tweaked-1.80pr1.13.jar (by default, i didn't change anything)

Logs If I use the command equip 1 left it says: "Item not equippable" If I use lua (turtle.equipLeft() or turtle.equipRight())to equip it it says: 

false
Not a valid upgrade

I tried crafting it with a Diamond Pickaxe and Diamond Sword in my inventory, in the vanilla crafting table, in the tinkers crafting station and in the Tier 1 Basic Crafting Table. (Yeah I'm kind of desperate, i really want my turtle :D)

Screenshots

https://imgur.com/a/NTBfAAa

Additional context

I also tried my tinkers pickaxe but it didn't work. But if i remember correctly the shouldn't work since you can only equip tools which you can craft with the turtle (the diamond tools)

Maybe a starting point: The code that produces the "Item is not equippable" should be this one: SquidDev-CC/CC-Tweaked /src/main/java/dan200/computercraft/shared/turtle/core/TurtleEquipCommand.java with Tag v1.80pr1.13

Its the first expert modpack I played and I'm really impressed! We're having a lot of fun going through the quests and being forced to use all mods - even the ones we normally skip ;) The modpack is awesome, thanks a lot!

NielsPilgaard commented 5 years ago

Thank you for your kind words :D

This issue is related to https://github.com/SquidDev-CC/CC-Tweaked/issues/97

@SquidDev can you shed some light on this issue when you have time? :)

SquidDev commented 5 years ago

So turtles basically check if the provided item is stackable with the upgrade's one (same item, damage, NBT). The only reason I could think that it's not seeing the upgrade is if pickaxes have some additional NBT, or if they a different damage value. I notice the max damage is set to one, but that shouldn't cause issues.

I'll have a play locally and see if I can work out what's going in on more detail. I've a couple of hunches, so we'll see...

SquidDev commented 5 years ago

This should be fixed in the latest version. Let me know if you still experience issues!

NielsPilgaard commented 5 years ago

Ooh nice timing, I'll sneak it into update 1.53, thank you :D