MaxNeedsSnacks commented 5 years ago

This is a thread compiling users' unification problems into one issue for the sake of clarity.

(and also so I can just fix all of them within one large PR :P)

Please read this before contributing!

Please tell me which item you were trying to craft and how.
If possible, please also provide item / recipe IDs, it makes things a hell of a lot easier to fix for me ^^
Please avoid duplicates in this thread, including those of already existing issues

That's all for now. I'm gonna try to fix these as soon as I see them and add them to a PR you can soon check out and review for yourself.

(Now, if you'd excuse me, I'm going to go through some items myself and see whether I can find any errors with unification)

MaxNeedsSnacks commented 5 years ago

Looks like I accidentally removed Mystical Agriculture Sulfur unification when reverting 6ccd331 in #880, whoops! I'll be readding that real quick.

NielsPilgaard commented 5 years ago

Good idea :D

MaxNeedsSnacks commented 5 years ago

Just added Uranium unification (closing #909) to the mix and also changed Amber Essence to output Thaumcraft amber, just seems more sensible to have it output that.

NielsPilgaard commented 5 years ago

Sweet!

Wntermute commented 5 years ago

Here are a few:

IF laser yields IC2 Copper Ore that isn't OD'd to oreCopper
Also yields IC2 Tin Ore that isn't OD'd to oreTin
NuclearCraft and IC2 both have items called Uranium 235 and Uranium 238, why not combine them? (Preferably the safe-to-handle NC one ^_^) = FluidDict the various liquid honeys (Animania, Forestry, BoP, Rustic) = For some reason, I ended up with tons of Rustic and HarvestCraft beeswax that couldn't be made into Forestry
The Klein Bottle recipe. My automation keeps using my Clear Glass for other things and I unsuccessfully tried to DEUNIFY Clear Glass.

The ones marked with a = I managed to CraftTweak into my server.

PS. I also managed to work around the NuclearCraft Alloy Furnace automation issue with the Fused Quartz recipe by adding one using 2 Nether Quartz and 2 Black Quartz, it kept putting all the nether quartz for the 2+2 recipe into one slot.

MaxNeedsSnacks commented 5 years ago

@Wntermute the IF laser shouldn't yield IC2 ores, I checked through the laser config and in-game JEI tooltips and it doesn't seem to. Can you try confirming that in a new world?

I also just checked and apparently Rustic honey simply... isn't a thing when other honeys are around. I tried picking up the Rustic honey and it auto-turned into BoP honey ^^

Finally, considering the clear glass one, I'm not sure whether I want or should change that honestly since having Clear Glass OD'd as blockGlass might help for example players in the earlier game stages as a way to get glass more quickly through the smeltery

NielsPilgaard commented 5 years ago

I would prefer if you didn't Max :)

MaxNeedsSnacks commented 5 years ago

Had a hunch, honestly, wouldn't make sense to remove Clear Glass from that OD. Guess @Wntermute will just have to find another way to not waste it then :P

NielsPilgaard commented 5 years ago

Like disabling substitutes :)

MorganSimic commented 5 years ago

Also the liquid honey stuff is already done a few updates ago. I did merge all liquid honey obtaining ways into forestry honey. If you could point out exact cases where honey isn't unified that would be great @Wntermute. Also The IF meat ore processing puts out ic2 dusts. I'm not sure if changing that is possible at all. Haven't run into any issues though.

Wntermute commented 5 years ago

OK, I started a new single-player world, set up a laser in creative and chunkloaded the chunk, left it running all day while I looked around for other possible sources of IC2 ore. After a plethora of hours, 0 IC2 copper/tin and it had barely filled half of one page of a Large Storage Crate.

I DID however find IC2 Ingots in village/dungeon crates, so it's possible I got some from there. Either way, they don't work in the Mekanism ore processing chain I have set up and won't go into my already existing drawer w/ OD upgrade.

As for the honey, I'm pretty sure it was Rustic honeycomb + Centrifugal Separator that prompted me to make a workaround. It's possible it was in 1.47 (where I started), 1.49, or 1.53. I just updated to 1.55 the day before 1.56 came out and so I'm holding off on 1.57 to update again.

And to clear up (pun intended) the request for the Clear Glass.. I'm not looking to have you deunify it.. Just unify the Klein Bottle recipe to use ore:blockGlass. That's about the only thing I had trouble with and have seen require the Clear variety. (Haven't gotten to Quite Clear yet, still need titanium)

MorganSimic commented 5 years ago

Thanks, i will take a look. In theory that should work now, as I did implement that aswell.

NielsPilgaard commented 5 years ago

The Klein Bottle recipe is meant to be annoying, sorry :P

I thought I removed the ic2 ingots from dungeon loot, damn.

MorganSimic commented 5 years ago

I tested rustic honeycombs with all methods of obtaining honey from them and they all yield Forestry honey as intended. My unification was merged in 1.55, so if you tried before you will have run into issues. Now it is working fine. To get the official fix, you may need to revert your internal changes depending on what exactly you did.

MaxNeedsSnacks commented 5 years ago

From what I can gather, he only added the various Honeys to the fluiddict converter (just like i did in the pr) so that shouldn't cause any issues hopefully

edit: whoops apparently ctrl enter just... closed the issue. Sorry for that!

MorganSimic commented 5 years ago

That's all fine. I don't think that conversion was necessary, because all producable honey is forestry honey now. Maybe for animnia and bop honey. I didn't touch animania honey since I now nothing about it and it doesn't seem to have any processing attached to it. And you can obtain bop honey still through nether hive worldgen. So if you really want to you can use that.

Wntermute commented 5 years ago

Do we need two sawdusts with the same recipes?

&

MaxNeedsSnacks commented 5 years ago

I might add Sawdust to the UniDict forced entries, just for the sake of not clogging up your ME

Wntermute commented 5 years ago

OK, get this.. Moved the IC2 ores out of my RS system into a chest and left it running most of the day.. 2 new IC2 Copper and Tin ores. Maybe readding them to ore:oreCopper/ore:oreTin.. Or add a recipe to turn them into the normal Copper and Tin. Best you can do is x2 via Manufactory and I have a nice x3 Mekanism system set up.

Don't know what to say, the Mekanism laser is my current source of ore since I haven't mined other than clearing out a room to make ghasts to get chunks.

NielsPilgaard commented 5 years ago

Err Mekanism Laser for ores? Do you mean IF?

Wntermute commented 5 years ago

Oops, yes.. It's been a long day. It's that one instead of the Void ore miner, which I haven't set up yet

NielsPilgaard commented 5 years ago

fixed :D

MorganSimic commented 5 years ago

Mekanism crusher does output Mekanism diamond dust instead of IC2 diamond dust. It is usuable for all intends and purposes but is confusing, since it doesn't show up anywhere in JEI.

Kallado commented 5 years ago

Mekanism crusher produces EnderIO Lapis Lazuli Powder, not IC2 Lapis Lazuli Dust like other similar processes. They're still OD'd to each other, so nothing is broken. I'm just assuming that the powder is meant to be disabled completely.

MaxNeedsSnacks commented 5 years ago

I don't think there's much more unification to do here, if anyone still has any issues, feel free to open a new issue / PR or just comment on here

EnigmaticaModpacks / Enigmatica2Expert

Unification Error Megathread #913

This is a thread compiling users' unification problems into one issue for the sake of clarity.

(and also so I can just fix all of them within one large PR :P)

Please read this before contributing!