EnigmaticaModpacks / Enigmatica6

The official repository and issue-tracker for Enigmatica 6
https://www.curseforge.com/minecraft/modpacks/enigmatica6
241 stars 520 forks source link

Integrated Dynamics' Energy Battery recipe invalid in crafting interface on world reload #3207

Closed CosecantX closed 2 years ago

CosecantX commented 3 years ago

Modpack Version

0.5.9 but likely in 0.5.11

Describe your issue

I couldn't find a report for this on here or the change log, so I assume it's still an issue.

When setting up a crafting interface to allow autocrafting of ID energy batteries, the recipe card is initially accepted and works as intended. However, when the world is quit and reloaded, the recipe is marked as invalid and has to be cleared and replaced with a new, otherwise identical recipe card. As far as I can tell, nothing short of making a new one will actually fix the issue.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

Yes

User Modifications

Optifine

Did the issue happen in singleplayer or on a server?

Singleplayer

NielsPilgaard commented 3 years ago

I suspect this is fixed in 0.5.11, please try updating :)

CosecantX commented 3 years ago

Just tested in 0.5.11, still happening, unfortunately. After creating the test network I restarted the game and it happened. I'm not sure if it happens when just reloading the world, but if you can't get the bug to happen with just reloading then try restarting the game. This instance was completely unmodified. No Optifine, no config changes, etc. Untitled

NielsPilgaard commented 3 years ago

Thanks for trying that :D Would you mind also updating the Integrated mod suite? If you'd rather not you can wait for 0.5.12, but there's no ETA on that yet.

CosecantX commented 3 years ago

I updated the two Integrated mods that weren't up do date, and the issue still applies. I tried testing some other objects and found that the portable batteries from Powah do the same thing. maybe there's an issue with things that hold RF and start with an empty durability gauge? I'm not a modder so I don't really know the ins and outs of how any of that works. Untitled

NielsPilgaard commented 3 years ago

Nice, thanks! Could you please provide your latest.log? I'm relaying the issue now :)

CosecantX commented 3 years ago

Hope this helps! latest.log

NielsPilgaard commented 2 years ago

Would you mind putting the below config file in your config folder and see if it fixes the issue? :) commoncapabilities-common.zip

CosecantX commented 2 years ago

Nope, didn't work, unfortunately. Tested in version 0.5.14.

NielsPilgaard commented 2 years ago

Alright, thanks for testing 👍

rubensworks commented 2 years ago

@CosecantX ID dev here. Could you try loading the following dev builds, open the crafting writer, and re-insert the offending variable cards? These build will include some debug output in the logs, which will help me debug this issue. If the logs contain something starting with Recipe validation failure:, could you send me the full logs?

(you can just download the asset ending with [some-version].jar)

GitHub
Package org.cyclops.commoncapabilities.commoncapabilities · CyclopsMC/packages
Maven repo for CyclopsMC mods. Contribute to CyclopsMC/packages development by creating an account on GitHub.
GitHub
Package org.cyclops.integratedcrafting.integratedcrafting · CyclopsMC/packages
Maven repo for CyclopsMC mods. Contribute to CyclopsMC/packages development by creating an account on GitHub.
CosecantX commented 2 years ago

This is the "recipe validation failure" part:

[03Oct2021 03:26:10.949] [Server thread/INFO] [integratedcrafting/]: Recipe validation failure: incompatible recipe output and simulated output: Recipe output: [MixedIngredients ingredients: {[IngredientComponent minecraft:itemstack 1736787708]:[integrateddynamics:energy_battery 1 {energy:0}]}] Simulated output: [MixedIngredients ingredients: {[IngredientComponent minecraft:itemstack 1736787708]:[integrateddynamics:energy_battery 1 null]}] [03Oct2021 03:26:10.958] [Server thread/INFO] [integratedcrafting/]: Recipe validation failure: incompatible recipe output and simulated output: Recipe output: [MixedIngredients ingredients: {[IngredientComponent minecraft:itemstack 1736787708]:[integrateddynamics:energy_battery 1 {energy:0}]}] Simulated output: [MixedIngredients ingredients: {[IngredientComponent minecraft:itemstack 1736787708]:[integrateddynamics:energy_battery 1 null]}] [03Oct2021 03:26:10.966] [Server thread/INFO] [integratedcrafting/]: Recipe validation failure: incompatible recipe output and simulated output: Recipe output: [MixedIngredients ingredients: {[IngredientComponent minecraft:itemstack 1736787708]:[integrateddynamics:energy_battery 1 {energy:0}]}] Simulated output: [MixedIngredients ingredients: {[IngredientComponent minecraft:itemstack 1736787708]:[integrateddynamics:energy_battery 1 null]}]

I've also attached the full log. latest.log

rubensworks commented 2 years ago

Thanks for checking @CosecantX! I should have enough information with this to fix the problem.

rubensworks commented 2 years ago

@CosecantX Could you try out the latest CommonCaps dev build again? (https://github.com/CyclopsMC/packages/packages/769964)

Together with the config change that @NillerMedDild gave you, this dev build should fix the problem. Could you confirm that this also works on your end?

GitHub
Package org.cyclops.commoncapabilities.commoncapabilities · CyclopsMC/packages
Maven repo for CyclopsMC mods. Contribute to CyclopsMC/packages development by creating an account on GitHub.
CosecantX commented 2 years ago

that fixed it! thanks!

rubensworks commented 2 years ago

Great, thanks for the help @CosecantX!

rubensworks commented 2 years ago

@NillerMedDild FYI, in order for this fix to apply, the CommonCapabilities mod will require a config file reset for the next release (or manually making the config change I mentioned before).

NielsPilgaard commented 2 years ago

Thanks, I just applied the change :)