EnigmaticaModpacks / Enigmatica6

The official repository and issue-tracker for Enigmatica 6
https://www.curseforge.com/minecraft/modpacks/enigmatica6
241 stars 522 forks source link

Enigmatic Graves duping/overwritting items with Soulbound #3694

Open staviq opened 2 years ago

staviq commented 2 years ago

Modpack Version

0.5.20

Describe your issue.

If after dying, player switches to spectator mode and back, soulbound items will get weird when clicking on the grave.

Example: I had two swords, one diamond i bought from traveling merchant, and one i looted that had soulbound on it, both diamond enchanted swords. When i died, i did F3+N to get to my items, and when i switched back from F3N, clicking my grave replaced one of my diamond swords with the other and now i have two identical enchanted diamond swords instead of two diffrent enchanted diamond swords. Essentially one item turned into the other one, but the original item was kept.

"Duplicated" items persist through server restart.

I restored world from backup and tested it again and the problem is reproducible.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Server

MuteTiefling commented 2 years ago

Thanks for the report. Are you certain that spectator mode is a requirement for this? You weren't in it when you claimed the items, if I'm understanding properly.

staviq commented 2 years ago

Thanks for the report. Are you certain that spectator mode is a requirement for this? You weren't in it when you claimed the items, if I'm understanding properly.

When i realized i have two identical swords in my inventory, i rolled back my world from backup several times until i found one backup that had my two swords intact, then i went and died on purpose, i then respawned in my bed, went on foot to where i died and picked up my grave, and everything was fine. So then i again got myself killed, this time i went into spectator mode to get out of my house quicker, then outside the house i switched back from f3n to normal mode and on foot approached my grave and picked up my items, and then the swords got mixed up.

So i would seem like switching to spectator mode and back is requirement for reproducing this problem, but i haven't tested it enough to confirm that this is the only way to cause this problem.

MuteTiefling commented 2 years ago

I'm having a hard time reproducing this.

Upon dying, I respawn and collect my things without fault even if I enter spectator mode and leave it prior to collecting my items.

Darkere commented 2 years ago

Soulbound is probably also a requirement for this bug.

MuteTiefling commented 2 years ago

Oh good call. Will try that

MuteTiefling commented 2 years ago

Yeah, even with soulbound on the weapons I'm getting back exactly the tools I had at death.

Also tried clicking the grave vs sneaking on it. No difference. I get the right stuff back... Still, will report to Quarris, just might be harder to track down if we can't reproduce.

MuteTiefling commented 2 years ago

Ah, no. Got it. Happens if only one of the swords has soulbound.