Mod Interaction Bug: Create Harvester and Cindercane

[romeara]

Modpack Version

0.5.20

Describe your issue.

When attempting to utilize Harvesters from the Create mod to farm Cindercane from the "Project Vibrant Journeys" mod, no interaction occurs.

Expected: Cindercane should harvest the same way sugarcane does when interacting with this block

I was not sure if the harvester interactions are tag-based, or some other configuration controlled by the pack, or if there is an issue within the mod(s) themselves recognizing the item/entity correctly. I apologize if this belong in one of mod's own bug trackers, if it does please point me in the right direction and I'll file the issue there.

Crash Report

No response

Latest Log

https://pastebin.com/X4A3DiTF

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

[Quezler]

looks like it does not extend sugarcane, though there is a check for iPlantable which the block seems to implement too, not 100% sure where it's going wrong 🤔

[Darkere]

looks like we might be able to give it a leaves block tag to fix it? Might have sideffects

[Quezler]

yea, saw that too but it's probably not the best of ideas for the reason listed ^

[Darkere]

IPlantable isn't working because the for loop above it is broken. Feel like making a PR? :D

[YashTFEM]

Did you try using a harvester? Sometimes that works.

[Quezler]

i guess you could try, their 1.16 branch is still being maintained despite them having moved development to 1.17 🤔

(might as well add a create:harvastable tag or smth to opt in certain blocks, it certainly wouldn't be the first tag)

[YashTFEM]

Oh wait, sorry, I meant saw not harvester. Saw works for cactus so it might work for sugarcane

[YashTFEM]

Sorry cindercane, not sugarcane

[Quezler]

cindercane doesn't trigger the saw either

[romeara]

Hi! Sorry, I forgot to mention that I also tried a saw and deployer with no effect

Also, the farm design itself was previously verified in the same save on kelp

[NielsPilgaard]

IPlantable isn't working because the for loop above it is broken. Feel like making a PR? :D

Lines 51-53 should be removed entirely, right?

[Darkere]

https://github.com/Creators-of-Create/Create/blob/dfe2f41b59d91bd9bbf11fb6bca7b260dc1c47fe/src/main/java/com/simibubi/create/content/contraptions/components/actors/HarvesterMovementBehaviour.java#L162

That for loop just returns false if the block has the AGE_1 property. Which most plant blocks should have, I think? (The code is awful, that aside)

https://github.com/OrderedChaos-Dev/ProjectVibrantJourneys/blob/54da0ddf8e1bb0c7dc41fa5f04562b0268d2d757/src/main/java/projectvibrantjourneys/common/blocks/CindercaneBlock.java#L52

that is just a weird way to find out how many of the same blocks are beneath it

GitHub

Create/HarvesterMovementBehaviour.java at dfe2f41b59d91bd9bbf11fb6bca7b260dc1c47fe · Creators-of-Create/Create

[Forge Mod] Building Tools and Aesthetic Technology - Create/HarvesterMovementBehaviour.java at dfe2f41b59d91bd9bbf11fb6bca7b260dc1c47fe · Creators-of-Create/Create

GitHub

ProjectVibrantJourneys/CindercaneBlock.java at 54da0ddf8e1bb0c7dc41fa5f04562b0268d2d757 · OrderedChaos-Dev/ProjectVibrantJourneys

Minecraft mod that expands in all directions. Contribute to OrderedChaos-Dev/ProjectVibrantJourneys development by creating an account on GitHub.

[romeara]

Anything I can do to assist with this? I might be able to bumble through putting a PR together (Java I know, Minecraft mod architecture less so), but I am unclear if there is consensus of which approach to take