fix #5379 - Githubissues

EnigmaticaModpacks / Enigmatica6

The official repository and issue-tracker for Enigmatica 6

https://www.curseforge.com/minecraft/modpacks/enigmatica6

240 stars 528 forks source link

fix #5379 #5437

Closed ZZZank closed 5 months ago

ZZZank commented 5 months ago

This PR, combined with my previous PRs(like #5435 ), fixes #5379 , with some additions.

This PR enables localizations for:

Special custom items
Multiblock gamestage error message
Custom Amadron trades

and

provides corresponding zh_cn localization for new entries
use JSON.stringify to generate nbt string, for a better format
~~fixes some wrong translations I made in #5435~~ Switched to Crowdin

ZZZank commented 5 months ago

I also hava a problem: When will Crowdin project gets update? I'm asking this because of those translation errors I made in PR4535. They are not severe errors, just missing "bucket" when localizing fluid bucket names, but they're still errors. Translating on Crowdin can largely avoid and qiuckly fix those errors, because there's more participants.

NielsPilgaard commented 5 months ago

Thanks for the contribution, I'll review within a day or two 👍

I also hava a problem: When will Crowdin project gets update?

I've just synced, so it should be good now - Apparently it got stuck in December 2022 😅

NielsPilgaard commented 5 months ago

Excellent PR as usual, thank you 😊