EnigmaticaModpacks / Enigmatica6

The official repository and issue-tracker for Enigmatica 6
https://www.curseforge.com/minecraft/modpacks/enigmatica6
240 stars 528 forks source link

[Expert] IE Assembler fluid crafting not working unless using filled bucket #5446

Open Rendernull35 opened 3 months ago

Rendernull35 commented 3 months ago

Modpack Version

1.9.0

Describe your issue.

IE assembler doesn't try to craft recipes with fluids (IE lv capacitor, RS/Modular Router/PneumaticCraft speed upgrades, and Mek energy cubes) using fluid stored on multiblock, if filled buckets are used they still work as intended, recipes without fluids works as intended.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

Yes

User Modifications

Mods Added: Easy Villagers, Embeddium, Embeddium Extra, Lightspeed, TexTrue's Embeddium Options, Sulfuric, Not Enough Crashes, FPS Reducer

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

null9463

MuteTiefling commented 3 months ago

Thanks for the report.

Looks like this is caused by our particular recipe structure for this recipe.

We use this

        {
            output: 'immersiveengineering:capacitor_lv',
            pattern: ['ABA', 'CDC', 'AEA'],
            key: {
                A: '#forge:treated_wood',
                B: 'immersiveengineering:connector_lv',
                C: '#forge:plates/lead',
                D: Item.of('thermal:fluid_cell').ignoreNBT(),
                E: {
                    type: 'pneumaticcraft:fluid',
                    tag: 'pneumaticcraft:etching_acid',
                    amount: 1000
                }
            },
            id: 'immersiveengineering:crafting/capacitor_lv'
        },

Changing it to this, works.

        {
            output: 'immersiveengineering:capacitor_lv',
            pattern: ['ABA', 'CDC', 'AEA'],
            key: {
                A: '#forge:treated_wood',
                B: 'immersiveengineering:connector_lv',
                C: '#forge:plates/lead',
                D: Item.of('thermal:fluid_cell').ignoreNBT(),
                E: 'pneumaticcraft:etching_acid_bucket'
            },
            id: 'immersiveengineering:crafting/capacitor_lv'
        },

Now, the primary reason for using the pneumaticcraft function there is so that you can manually craft in batches with a PNC tank: image

This, unfortunately, breaks if we use the recipe format that works with IE: image

I'm not sure there's a way to combine these two options...

ZZZank commented 3 months ago

Immersive Engineering itself also adds a fluid ingredient type:

        {
            "amount": 1000,
            "tag": "forge:creosote",
            "type": "immersiveengineering:fluid"
        },

It should allow batch crafting in crafting table, while also keeps compatibility with Assembler(I mean, they are from the same mod). Give it a try?

MuteTiefling commented 3 months ago

I'll test that out. It's been a hot minute but I seem to recall moving over to the PNC method specifically due to this not working in 1.16. But it's been too long to remember at this point.