EnigmaticaModpacks / Enigmatica8

The official repository and issue-tracker for Enigmatica 8
42 stars 74 forks source link

Quest Rework Part 3 + Some Fixes #335

Closed Kanzaji closed 1 year ago

Kanzaji commented 1 year ago

Part 3 of my quest rework started back in the summer of 2022 😅 Introducing:

This PR resolves:

334

332

330

267

265

To Do:

Kanzaji commented 1 year ago

Also, I forgot to send a preview of new Trophies ^^" The file is pretty big, so here is a link for anyone that wants to see it: https://cdn.discordapp.com/attachments/730169148294037544/1061374487611834369/2023-01-07_21-01-47.mp4 For Contributors, the video is on the #contributor-chat https://canary.discord.com/channels/195234321836146688/730169148294037544/1061374489700602029

Kanzaji commented 1 year ago

Alrighty, got a response from Trofes Dev, and I was able to get info why the trophies with IF sounds didn't want to work ^^" It seems that client-sided sound effects can not be used for Trophies sounds. Anyway, Ready to review / merge 😄

Kanzaji commented 1 year ago

So I decided to do a bit more of Formatting, and would need some opinions about it ^^" I would love to add some colors and decorations to all the quests, but that will take really long time, and I think it is better if I would do so in Enigmatica 9. obraz obraz obraz obraz obraz PS: Chapters are possible to just click, and they will open correct quest lines!

NielsPilgaard commented 1 year ago

I agree that large scale improvements would be a better fit in E9.

PS: Chapters are possible to just click, and they will open correct quest lines!

That is freaking awesome.

Kanzaji commented 1 year ago

Alrighty! Gonna work on formatting for E9 quests as well, so now question. Should I revert formatting changes to the Welcome Chapter, or leave it like that for E8?

NielsPilgaard commented 1 year ago

Alrighty! Gonna work on formatting for E9 quests as well, so now question. Should I revert formatting changes to the Welcome Chapter, or leave it like that for E8?

Leave it like that for E8 please, it looks good :)

Kanzaji commented 1 year ago

That is pretty much what happens when I try to do quest work when I'm tired 😅 Anyway typos fixed

Kanzaji commented 1 year ago

Was the Jetpack change intentional? 😄

Yea ^^" After a bit of thinking it didn't make much sense tbh.

Kanzaji commented 1 year ago

I've read those changes 4 times and can't find anything else wrong, so I would say yes 😄 Would love to get some more formatting work done, but like we decided earlier, I think it is better if I do that for Enigmatica 9.