EnigmaticaModpacks / Enigmatica9

The official repository and issue-tracker for Enigmatica 9
35 stars 59 forks source link

Cannot connect to server on version 1.8.0 #451

Closed sniggyfigbat closed 11 months ago

sniggyfigbat commented 11 months ago

Modpack Version

1.8.0

Describe your issue.

We've just attempted to upgrade from 1.3.0 to 1.8.0, and we cannot log into the server. The issue is exactly the same as the one seen in #229 but the workaround posted there hasn't worked.

With the refinery.js and smelter.js files removed, we now get the following error (server-side) upon joining: Lorcogoth lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.ClassCastException: class cofh.lib.util.crafting.IngredientWithCount cannot be cast to class dev.latvian.mods.kubejs.platform.forge.ingredient.KubeJSIngredient (cofh.lib.util.crafting.IngredientWithCount is in module cofh_core@10.2.1 of loader 'TRANSFORMER' @3e0a9b1d; dev.latvian.mods.kubejs.platform.forge.ingredient.KubeJSIngredient is in module kubejs@1902.6.0-build.142 of loader 'TRANSFORMER' @3e0a9b1d)

Crash Report

No response

Latest Log

https://gist.github.com/sniggyfigbat/990d5a617f5e3c8380bde82beadf7567

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Server

Discord Username

No response

skrcka commented 11 months ago

same issue

NielsPilgaard commented 11 months ago

Damn, I should've caught that in testing 😅

While we work on resolving this issue, I recommend downgrading to 1.7.2. It might be a little while, sadly.

sniggyfigbat commented 11 months ago

@NielsPilgaard Hi dude. Just so you know, I tried swapping out crystallizer.js with the version from #452, and it didn't resolve the issue. Not sure if there was some additional change I missed. The error in the log didn't change, either.

Just as an aside, I just want to say how much I appreciate the speed with which you've addressed this. One of the reasons we always pick Enigmatica whenever we run a server is because of the incredible work you and your team do.

sniggyfigbat commented 11 months ago

Ah, I spotted this error in the logs with the amended crystallizer.js: Line 2682: [02jul.2023 20:13:05.867] [main/ERROR] [KubeJS Server/]: ! #75: Error occurred while handling event 'ServerEvents.recipes': TypeError: Cannot call method "toJson" of undefined (server_scripts:normal/recipes/thermal/crystallizer.js#75)

I amended line 75 to:

if (recipe.fluid) {
    recipe.ingredients.push(recipe.fluid.toJson());
}

but alas, it didn't resolve the issue.

sniggyfigbat commented 11 months ago

OK, I tried the nuclear option and tried removing the entire thermal recipes folder from base, normal, and expert, and it let me onto the server. Next step: trawling through every damn one of those files until I work out which of them is broken.

Kanzaji commented 11 months ago

Just to save you the trouble... normal Thermal scripts are the one that are broken, and real fault is on Therrmal's fault 😅

Darkere commented 11 months ago

Thermal will be releasing a fix next week. We might be fixing it from our side before that.

sniggyfigbat commented 11 months ago

Righto'. Just so you all know, the broken script is kubejs\server_scripts\normal\recipes\thermal\press.js. I couldn't work out how to translate the 4x #forge:gems/${gem} thing to standard json, unfortunately, so for now if anyone else has my issues then just remove that file and live without the Thermal expansion press for a while.

MuteTiefling commented 11 months ago

@sniggyfigbat Would you mind grabbing the thermal recipes from #455 and trying them on your server?

sniggyfigbat commented 11 months ago

@MuteTiefling I've grabbed the files, rebooted the server, seems to be working fine.