search

EnigmaticaModpacks / Enigmatica9

The official repository and issue-tracker for Enigmatica 9
37 stars 57 forks source link

Disabled itema are obtainable in some structures #844

Open YocyCraft opened 8 months ago

YocyCraft commented 8 months ago

Modpack Version

1.18.0

Describe your issue.

I obtained disabled item in the ancient mine structure. 2024-01-11_18 01 14 seed: -6928260298223639879 /execute in minecraft:overworld run tp @s -5308.03 -9.00 5583.25 -2238.61 25.50

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

No response

theboo commented 8 months ago

Sadly this is because IDAS has a metric butt load of hard coded loot(chests and such that are saved in the structure with items in them rather than as loot tables). I have my theories as to how this happened, and it wasn't on purpose, but it means our scripts that remove this stuff won't do anything on these non loot table inventories so we'd have to manually fix them all which would take an insane amount of time. This has been reported to idas along with a list of offending inventory locations in structures, but even though they said they would get it fixed, it has been well over a year now and nothing.

HeatherComputer commented 8 months ago

Could a fix not be automated in any capacity from the pack's end?

MuteTiefling commented 8 months ago

We have two options.

  1. Clean the structure files up ourselves and include them as is. This could be somewhat automated, but is still a lot of work due to the size and number of them. It's something I really just haven't felt like doing.

  2. Offload that same automation to the client each and every time they load a structure, which is very hard on world gen.

In either case, every single broken loot would end up being given the same generic table, for better or worse.

We did use automation to read out all the broken containers and provide them to the mod authors a year ago. There were so many that I think they were too discouraged to fix it.

HeatherComputer commented 8 months ago

Hmm. That's a bit of a shame.

Do you have a link to the issue you made for the mod authors?

theboo commented 8 months ago

There is no issue, it was reported through discord.. there is a thread just for it tho I can point you to if you want, talk to me on discord and I can explain further what I think happened as well if you want.