search

EnigmaticaModpacks / Enigmatica9

The official repository and issue-tracker for Enigmatica 9
35 stars 59 forks source link

spark profiler is set to autorun when single player (client) or server starts #908

Open DoomSquirter opened 2 months ago

DoomSquirter commented 2 months ago

Modpack Version

1.9.1

Describe your issue.

in ./config/spark/ the config there is set to true that starts the profiler while server is booting. I don't have experience with client since I'm playing with server but the same setting is on the client as well

This means an extra load is put on server that's unnecessary and every time you do an actual profiler, after doing one it auto restarts it cause of that setting I think

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Server

Discord Username

DoomSquinter

MommyHeather commented 2 months ago

It's worth noting that spark profiles have next to no impact on server performance - though I can confirm having some oddities when trying tj start a profiler of my own, and an autostarting profiler does not sound like something that should be enabled by default.

MuteTiefling commented 2 months ago

So, I don't think this is actually set true in our configs. At least not that I'm seeing. @Darkere is it normal that backgroundProfiler defaults to true?

Darkere commented 1 month ago

yep seems like that is default