search

EnigmaticaModpacks / ModpackUploader

Automation tool for uploading Modpacks to CurseForge.
Apache License 2.0
15 stars 9 forks source link

changelog/modlist jar can't be retrieved if not latest #29

Closed FederAndInk closed 1 year ago

FederAndInk commented 1 year ago

Modpack Version

none

Describe your issue.

This doesn't work: https://github.com/EnigmaticaModpacks/ModpackUploader/blob/03ed0311fd8219921a3b9ee2a4dbea166cdf098d/modpack-uploader.ps1#L33 if this is not the latest file here: https://github.com/EnigmaticaModpacks/ModpackUploader/blob/03ed0311fd8219921a3b9ee2a4dbea166cdf098d/settings.ps1#L75

(currently the latest is 4.0.2)

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

No response

NielsPilgaard commented 1 year ago

Thanks for the report, I'll look into how to fix it :)

FederAndInk commented 1 year ago

Here is what I can think of:

  1. add a CHANGELOG_GENERATOR_VERSION variable and use it to construct the URL with the already provided filename $CHANGELOG_GENERATOR_JAR, and not relying on the github API
  2. search the tags for the filename provided

I think 1. would be good enough and is what is generally used in like package script