EnigmaticaModpacks / ModpackUploader

Automation tool for uploading Modpacks to CurseForge.
Apache License 2.0
16 stars 9 forks source link

Check for cf project status before adding mod to manifest #31

Closed MetaverseRPN closed 1 year ago

MetaverseRPN commented 1 year ago

Modpack Version

NA

Describe your issue.

For a good while now, I have had to manually modify my instances.json to keep curseforge from rejecting the pack. This is due to the fact that two 3rd party mods were submitted to curseforge and are stuck in the changes required state. One of them is optifine which should never be distributed with the pack, and the other is computronics which is on the 3rd party mod list but due to someone deciding to submit it to curseforge directly, the instances grabs it and Modpackuploader throws it into the manifest without a second glance at it. Having spoken with the devs in the Curseforge Dev channel, they told me to suggest you check the cf project status before adding it to the manifest: image image

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

No response

NielsPilgaard commented 1 year ago

Thanks for the report. I'm afraid I'm not willing to use the CurseForge API, I'm worried I'd somehow break the Terms & Conditions and face awful consequences 😅

Also, this tool doesn't actually support third party mods at the moment, as you found in #17