Unable to make a github release

[WFPhantom]

Describe your suggestion

First of all sorry for using the general suggestion template i just wasnt sure what else to use. Running the script produces this error: https://pastebin.com/XMPnUbXn and it doesnt make a github release.

Why would you like this added/changed?

.

[NielsPilgaard]

The issue is that the $MODPACK_VERSION that you defined in the settings.ps1 file is not a valid tag - I'm curious, what is it set to? 😄

[WFPhantom]

That's interesting I have it set to $MODPACK_VERSION = "0.2.3"

[NielsPilgaard]

That is.. strange 😄 does that tag already exist in your repo?

[WFPhantom]

No, i don't think so at least? my repo consists of a Readme.md and a modlist.md that was generated from the modpackuploader and I uploaded manually.

[NielsPilgaard]

Can you link your repo?

[WFPhantom]

Yeah i should've done that in the first place https://github.com/WFPhantom/Balanced-Eternal edit: Here is my settings.ps1 too https://pastebin.com/hEr14cx1

GitHub

GitHub - WFPhantom/Balanced-Eternal

Contribute to WFPhantom/Balanced-Eternal development by creating an account on GitHub.

[NielsPilgaard]

Ah, I was hoping settings.ps1 was in there 😅

[WFPhantom]

i figured, i edited my previous message

[NielsPilgaard]

Yeah that does look fine - Did your put your GitHub credentials in the secret.ps1?

[WFPhantom]

Yes, my github name, repository and token are all in there, here is my settings.ps1 with the CF and Github tokens removed for obvious reasons https://pastebin.com/JS7yGcD2 Could it be the permissions set up for the token?

Pastebin

# Secret settings for the ModpackUploader# For details/help see: https://githu - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

[NielsPilgaard]

Could it be the permissions set up for the token?

Yeaht that might be it.

[WFPhantom]

Well i gave it all perms and still same error 😅 Edit: Does it need to be a "fine-grained token" the one I'm using is a classic token

[NielsPilgaard]

I have no idea, I thought there was only one kind :P I'm afraid I don't know what's going on here.

[WFPhantom]

Assuming it works for the enigmatica modpacks its an issue on my end so I'll just close this issue if u want

[WFPhantom]

Hi there, i figured i out! my main branch is called main and not master I have no idea why tbf but changing the target_commitish in modpack-uploader.ps1 from master to main fixed it, whoops. Thank you for your help!

[NielsPilgaard]

Ahh that makes sense, I'll get that fixed on my end, thanks 👍 no reason for it to be hardcoded to master

[NielsPilgaard]

All patched up 👍

https://github.com/EnigmaticaModpacks/ModpackUploader/releases/tag/2.5.2

GitHub

Release 2.5.2 · EnigmaticaModpacks/ModpackUploader

Full Changelog: 2.5.1...2.5.2