Enigmatis / graphql-java-annotations

GraphQL Annotations for Java
Other
387 stars 97 forks source link

Add support for graphql-java v11 #189

Closed sergehuber closed 6 years ago

sergehuber commented 6 years ago

Here is an update to migrate to graphql-java 11. I didn't have much time to test but all the unit tests seems to run.

The main point that needs review is the changes in the AsyncConnectionDataFetcher as I'm not an expert with the CompletableFutures

sergehuber commented 6 years ago

Not sure why the build is failing it works fine locally. Maybe an issue with the build platform ? Also when I click on details I get a 404.

sergehuber commented 6 years ago

Ah now the details work again and I get : "Google Cloud Platform project is not set up correctly for this GitHub app. Please reinstall the app and go through the setup flow again"

yarinvak commented 6 years ago

Yea there's some problem with the ci configuration. I tried to fix this. Can you open a new PR please?

sergehuber commented 6 years ago

Ok I'll try again