search

Enigmatis / graphql-java-annotations

GraphQL Annotations for Java
Other
387 stars 97 forks source link

(deps) Updating to latest graphql-java:17.1 library #272

Closed setchy closed 3 years ago

setchy commented 3 years ago

Updating to the recently released graphql-java:17.0 library

As part of 17.0, the following breaking changes occured

Appreciate any feedback

setchy commented 3 years ago

Not sure why its trying to run the publish step. @yrashk :)

yarinvak commented 3 years ago

Hey @setchy thanks for you contribution. I'm not sure why you've removed the custom scalars? Can you elaborate on this?

setchy commented 3 years ago

Hi @yarinvak - no problems.

Re: the removal of the custom scalars, I have followed up again this morning on this graphql-java 17.0 release discussion thread as there seems to be a disconnect atm.

Initially there was no mention of the removal in the release notes. The revised release notes suggest they are now homed in the graphql-java-extended-scalars project, but that too hasn't quite happened.

Looks like the intention is to keep the 6 scalars though and re-home them. So with that said, I'll look to update this PR once a new version of extended-scalars is available (will update to graphql-java 17.1 at the same time)

setchy commented 3 years ago

@yarinvak - PR updated.

oliemansm commented 3 years ago

@yarinvak Any chance of getting this PR merged and a release published?

yarinvak commented 3 years ago

Hey @setchy , I've merged your PR but then I had to revert it because tests failed. Please pull changes from our development branch (I fixed the pipeline) and fix the failing tests, then create a new PR and I will merge.

Thanks for your contribution