Enigmatis / graphql-java-annotations

GraphQL Annotations for Java
Other
387 stars 97 forks source link

Improving GraphQL type handling and upgrading testng #288

Closed manikandan-ravikumar closed 1 year ago

manikandan-ravikumar commented 2 years ago

Partial update to entities

The purpose of this PR is to enable updation of selective entity fields. By introducing Optional, it also differentiates null from undefined

Let's assume an entity with 5 fields and the requirement is to update only one field to null. We can set the value of that field to null and omit other fields in a mutation query.

Changelog

manikandan-ravikumar commented 2 years ago

Hi @yrashk or anyone, Is it possible to push this PR further. We are planning to get rid of the fork that we have been using in our project and directly include this repo as a dependency. I have another related PR here https://github.com/Enigmatis/graphql-java-annotations/pull/287. I would really appreciate it if anyone could take a look 🙏

Fgerthoffert commented 1 year ago

Hi @manikandan-ravikumar,

We will be closing the PR for the time being, there are interesting improvements in your initial proposal but it required some work to be integrated into the codebase.

We don't have the bandwidth to do these changes ourselves for now, but if you're still interested, feel free to re-open the PR and submit the requested changes.

Thanks,