search

Enigmatis / graphql-java-annotations

GraphQL Annotations for Java
Other
387 stars 97 forks source link

Add Bnd instructions #294

Closed geichelberger closed 1 year ago

geichelberger commented 1 year ago

Without the Bnd instructions, the created OSGi manifest does not export any packages.

I added no uses because it was part of the old bundle.bnd file.

sergehuber commented 1 year ago

Hello,

We have since upgraded the GraphQL-Java version so could you please update this PR ?

Thanks, regards, Serge Huber.

geichelberger commented 1 year ago

I rebased it onto master.

The new graphql-java version has a faulty OSGi metadata Import-Package header referencing the android.os package.

https://github.com/graphql-java/graphql-java/pull/3313

sergehuber commented 1 year ago

Hello @geichelberger thanks for the quick update. I see you submitted a PR for the faulty import. Do you know if they merge these quickly ?

sergehuber commented 1 year ago

Ok I've reviewed the PR and all looks good so I merged it. As soon as graphql-java releases your fix we should update to it.

geichelberger commented 1 year ago

Hello @geichelberger thanks for the quick update. I see you submitted a PR for the faulty import. Do you know if they merge these quickly?

They seem to be pretty active, I hope it gets merged soon.