New colorblind themes aren't well supported

EnixCoda / Gitako

🐙 File tree extension for GitHub on Chrome & Firefox & Edge

https://chrome.google.com/webstore/detail/gitako/giljefjcheohhamkjphiebfjnlphnokk

MIT License

2.38k stars 103 forks source link

New colorblind themes aren't well supported #183

Closed jcready closed 3 years ago

jcready commented 3 years ago

See https://github.blog/changelog/2021-09-29-colorblind-themes-beta/

When the dark colorblind theme is enabled in GitHub settings the Gitako sidebar panel uses a light/white color scheme.

It looks like it could be fixed with just an additional case for data-dark-theme="dark_protanopia" in /src/styles/themes.scss

EnixCoda commented 3 years ago

Thank you for letting me know about this!

It seems that GitHub has updated the CSS variables available in DOM recently, I may update their references as well and check if any color in use has been deprecated.

kidonng commented 3 years ago

FYI:

EnixCoda commented 3 years ago

Supported in v3.5.1

Special thanks to @kidonng , the links are very helpful!