[Suggestion] Adding an entry for all characters to state what their codename is.

EnkaNetwork / API-docs

API documentation for the Enka.Network API responses and structure.

https://api.enka.network/

205 stars 45 forks source link

[Suggestion] Adding an entry for all characters to state what their codename is. #55

Closed ShikiSuen closed 11 months ago

ShikiSuen commented 11 months ago

For example: Kirara's codename is Momoka, Jean's codename is Qin, Lyney's codename is Liney, etc.

Algoinde commented 11 months ago

It's in characters.json in this repo. In addition, "codename" is not consistent across images. Use excels to get image URLs, not string concatenation.

ShikiSuen commented 11 months ago

@Algoinde Got it. Thanks. I found in this file that Kirara's namecard is not named using her codename.

9a82eeed-f3cd-4c97-b8ac-f279bfdf519e

Ah. I see. That's why Genshin Pizza Helper failed from getting Kirara's character background, requiring a fallback method reading the namecards.json.