search

EnlightenedPerlOrganisation / task-kensho

A Glimpse at an Enlightned Perl Distribution
http://search.cpan.org/dist/Task-Kensho
Other
71 stars 23 forks source link

Proposed fix for issue #49. #57

Closed manwar closed 5 years ago

manwar commented 5 years ago

Hi @Grinnz

Please review the PR, propose to fix issue #49

Many Thanks. Best Regards, Mohammad S Anwar

Grinnz commented 5 years ago

Thanks Mohammad, but I'm not the one in charge of changes here, and changes to the module list need to be done to modules.yml not the pod. It's also not really a fix, but a suggestion.

manwar commented 5 years ago

OK, I will update the modules.yml and rebase it

manwar commented 5 years ago

Done as suggested.

perigrin commented 5 years ago

Mohammad, thanks for the work on getting this into a PR.

I've left a question on #49 to see if this should be accepted or not.

manwar commented 5 years ago

@perigrin I am merely following the suggestions. I don't have personal opinion about this to be honest very honest with you.

I am getting an idea, I shouldn't create PR for issues listed as it hasn't been approved/accepted by the distribution owner.

karenetheridge commented 5 years ago

Creating pull requests for suggestions that haven't been discussed yet is not helpful -- the actual act of updating the yaml file is trivial and we do not need help with that. It is the determination of the content of the file that is where the effort lies.

manwar commented 5 years ago

I misunderstood the blog post asking for help. Feel free to close others as well :-)