Line hover colour - Githubissues

EnlighterJS / Plugin.ThemeCustomizer

EnlighterJS theme customizer component

Mozilla Public License 2.0

2 stars 0 forks source link

Line hover colour #2

Closed ajtruckle closed 4 years ago

ajtruckle commented 4 years ago

I am trying your new beta and see it now has a theme customizer.

I am trying to find the equivalent of:

Line Color

AndiDittrich commented 4 years ago

not implemented yet. it will follow in v4.1

ajtruckle commented 4 years ago

Ah, Ok. They seem to be my major issues:

Code

The hover colour (I can hardly see it). The highlight code colour doesn't stand out enough. Unlike the legacy version:

Code2

Well, the hover didn't actually work in bbPress because of the conflict but it does work in JS v3 which is good. Just the colour that is too pale. And a suitable highlight colour that is more noticeable.

The other good thing is when you hover the mouse over the code block the small icons show at top right now. :)

The only other observation is that:

the line numbers black in the legacy which is more noticeable.
the text is underlined for CSS samples when it wasn't before (this seems by design?)

Can you please notify me when 4.1 is out so I can have a look? I would like to update my site officially to your beta.

AndiDittrich commented 4 years ago

i've just added these settings to v4

the theme are currently not subjected to change - but you're welcome to create a pull request into the EnlighterJS repository including an enhanced colorscheme

ajtruckle commented 4 years ago

Thanks. I tried the current beta on my live site! And I also tried a different default theme:

Monokai:

Code3

Works good out of the box! When I tried a saved customized theme it did not display right. So rather than fight it I am sticking with these these.

AndiDittrich commented 4 years ago

the customizer has still some bugs, the next snapshot will fix a major one.

v4 will be released today or tomorrow - the Upgrade Notice are already in place: https://enlighterjs.org/wp-v4

AndiDittrich commented 4 years ago

the latest dev version is available on GitHub/Master

ajtruckle commented 4 years ago

Cool. By the way, I added a simple Additional CSS bit to override the display:none for your two classes with !important to get around the bbPress bug. Do for now.