Closed ajtruckle closed 4 years ago
not implemented yet. it will follow in v4.1
Ah, Ok. They seem to be my major issues:
The hover colour (I can hardly see it). The highlight code colour doesn't stand out enough. Unlike the legacy version:
Well, the hover didn't actually work in bbPress because of the conflict but it does work in JS v3 which is good. Just the colour that is too pale. And a suitable highlight colour that is more noticeable.
The other good thing is when you hover the mouse over the code block the small icons show at top right now. :)
The only other observation is that:
Can you please notify me when 4.1 is out so I can have a look? I would like to update my site officially to your beta.
i've just added these settings to v4
the theme are currently not subjected to change - but you're welcome to create a pull request into the EnlighterJS repository including an enhanced colorscheme
Thanks. I tried the current beta on my live site! And I also tried a different default theme:
Monokai:
Works good out of the box! When I tried a saved customized theme it did not display right. So rather than fight it I am sticking with these these.
the customizer has still some bugs, the next snapshot will fix a major one.
v4 will be released today or tomorrow - the Upgrade Notice are already in place: https://enlighterjs.org/wp-v4
the latest dev version is available on GitHub/Master
Cool. By the way, I added a simple Additional CSS bit to override the display:none for your two classes with !important to get around the bbPress bug. Do for now.
I am trying your new beta and see it now has a theme customizer.
I am trying to find the equivalent of: