EnlighterJS / Plugin.ThemeCustomizer

EnlighterJS theme customizer component
Mozilla Public License 2.0
2 stars 0 forks source link

Highlight whole row with Godzilla #3

Closed ajtruckle closed 4 years ago

ajtruckle commented 4 years ago

Hi !

So I have upgraded to your latest official v4 as released this afternoon. :)

On my live website I decided to try the Theme Customizer again.

I loaded Godzilla and then customised the line number hover colours. For some reason the = characters do not show with the required background:

CodeSample

AndiDittrich commented 4 years ago

one of the tokens has a background-color set - the line setting does only affect the line background not the tokens - its the intended behaviour

ajtruckle commented 4 years ago

one of the tokens has a background-color set - the line setting does only affect the line background not the tokens - its the intended behaviour

So where in the customiser do you adjust this particular = background colour? I have not specifically set anything myself for any tokens and it seems odd that by default this would be the case.

AndiDittrich commented 4 years ago
  1. use the element inspector to get the token name
  2. lookup the token name within the docs
  3. change the token in the customizer
ajtruckle commented 4 years ago

Thank you. I reviewed those documents and located k3.:

Operators

So, I then went to update the setting in the customiser:

Operators2

But when I click Save Changes it reverts back to #f0f0f0. Is this a bug?

I still don't understand why these tokens would have a background colour anyway since none of the others do. #confused

AndiDittrich commented 4 years ago

set it to none - you cannot "remove" settings from derived themes, you have to override them

ajtruckle commented 4 years ago

That work. Don't know what ramifications there would be by removing this default. Any way, it works. :)

Are you planning on showing the intended colour in a small square for any given colour setting?

AndiDittrich commented 4 years ago

in one of the next releases the colorpicker will come back - the default WordPress iris colorpicker was not suitable because it creates an instance for each input element which increases the page load time to 10s

maybe i have to change the value merging algorithm that empty fields can be used instead of overriding them

ajtruckle commented 4 years ago

Cool!