EnlighterJS / Plugin.ThemeCustomizer

EnlighterJS theme customizer component
Mozilla Public License 2.0
2 stars 0 forks source link

Theme Customizer does not work for .enlighter-t-wpcustom .enlighter span #6

Closed gruniversal closed 4 years ago

gruniversal commented 4 years ago

Hello,

I am not sure if this is a bug, but I hope you can help me.

Environment

Story

Example

<!-- wp:enlighter/codeblock {"language":"php","theme":"wpcustom"} -->
<pre class="EnlighterJSRAW" data-enlighter-language="php" data-enlighter-theme="wpcustom" data-enlighter-highlight="" data-enlighter-linenumbers="" data-enlighter-lineoffset="" data-enlighter-title="" data-enlighter-group="">
if ($result = $mysqli->query("SELECT Name FROM City LIMIT 10")) {
    printf("Select returned %d rows.\n", $result->num_rows);
    $result->close();
}
</pre>
<!-- /wp:enlighter/codeblock -->

Problem:

Proposed solution

Best regards, David

AndiDittrich commented 4 years ago

hi @gruniversal,

thanks for your feedback. the issue has already been arised.

EnlighterJS v3.3.0 already includes a em based font size which is derived from the outer container (global setting within the customizer) - implemented a few hours ago.

additionally a new generic group will be added to the Customizer which allowes the customization of the default token .enlighter span

AndiDittrich commented 4 years ago

image

gruniversal commented 4 years ago

Hello Andi,

I tried the new version 4.2 from GitHub (master, 20.4.2020) and it works on my staging system.

Thank you for your superfast reaction! That's impressive :)

Greetings from Leipzig, David

gruniversal commented 4 years ago

FYI: I wrote a script to migrate my codeblock entries from an old theme to a newer one and used it to successfully migrate from theme mocha to theme wpcustom.

It's very straightforward and only tested on my machine, but maybe someone will find it helpful: https://gitlab.com/gruniversal/wp-enlighter-migration