search

EnlighterJS / Plugin.TinyMCE

:pencil: Official EnlighterJS Plugin for TinyMCE
https://tinymce.enlighterjs.org
Mozilla Public License 2.0
11 stars 6 forks source link

Feature request - Hide the Theme label and drop-down list #6

Closed ajtruckle closed 4 years ago

ajtruckle commented 4 years ago

Please look:

enlighterjs-theme

I don't want any users selecting a different theme that the default. they won't know what the themes are anyway, and some of them don't render well due to issues with my WordPress theme. Also, I would like consistency across the site so that if I change my mind in what theme I use it will be applied everywhere.

So that this setting be visually removed?

AndiDittrich commented 4 years ago

you can rebuild the plugin and remove the specific line - there is no user controllable feature projected. as a workaround, you can alter the themelist and just set 1 theme to be active

ajtruckle commented 4 years ago

you can rebuild the plugin and remove the specific line

The above sounds complicated for me and then I foresee a maintenance issue with new upgrades to your plugin.

as a workaround, you can alter the themelist and just set 1 theme to be active

This idea does sound viable to me. Now I got to find in your documents how to do it.

ajtruckle commented 4 years ago

I found the sample code:

function mm_ejs_themes($themes){
    // just show the Classic + Enlighter Theme 
    // Add a new custom theme named my_c_theme - shown as 'MyCustom Lalala Themes' in select boxes
    // Note: Custom themes CSS has to be loaded separately
    return array(
         'Classic' => 'classic',
         'Enlighter' => 'enlighter'
         'MyCustom Lalala Themes' => 'my_c_theme'
     );
}

// add a custom filter to modify the theme list
add_filter('enlighter_themes', 'mm_ejs_themes');

At the moment I am using WPCustom so is the id wpcustom?

AndiDittrich commented 4 years ago

use print_r to view the content of the $theme array

ajtruckle commented 4 years ago

Confirmed:

Array
(
    [WPCustom] => wpcustom
    [Enlighter] => enlighter
    [Godzilla] => godzilla
    [Beyond] => beyond
    [Classic] => classic
    [MooTwo] => mootwo
    [Eclipse] => eclipse
    [Droide] => droide
    [Minimal] => minimal
    [Atomic] => atomic
    [Rowhammer] => rowhammer
    [Git] => git
    [Mocha] => mocha
    [MooTools] => mootools
    [Panic] => panic
    [Tutti] => tutti
    [Twilight] => twilight
)
ajtruckle commented 4 years ago

Although it is still a moot point because even if you use the sample and include one or two themes it will still be preceded by "Default (Global settings)" so this option (for both theme and programming language) are outside of this array list.

AndiDittrich commented 4 years ago

the "default" language setting has been removed in v4 - therefore it doesn't matter anymore

ajtruckle commented 4 years ago

Understood. I look forward to test driving v4 for you when it is operation and stable with bbPress 2.6.x.

AndiDittrich commented 4 years ago

did you tried it after applying the changes to your site ? it should work..

ajtruckle commented 4 years ago

did you tried it after applying the changes to your site ? it should work..

What changes? If you recall, you got me to switch on the "bbPress" option in the backend but nothing was working for me. Or has something since changed?

AndiDittrich commented 4 years ago

no but the v3 plugin didn't work on your site too because of the weak css rules. if your happy with v3 leave it as is for now

ajtruckle commented 4 years ago

no but the v3 plugin didn't work on your site too because of the weak css rules. if your happy with v3 leave it as is for now

I am happy with the one I have for now. The only reason I would like to upgrade is before of the fact that the popup toolbar does not display when you hover the mouse over the code and the current line of code does not highlight. Whilst this is not a big issue it does mean that I have to remember to attach the code as a raw attachment for now in the forum topic.

AndiDittrich commented 4 years ago

i can't follow you - mouseover on the current line is fully supported in EnlighterJS v2 and implemented by all official themes - see https://enlighterjs.org/Theme.Droide.html

ajtruckle commented 4 years ago

But as you already told me, bbPress conflicts with it and classes need disabling for it to function. And you told me v4 does not have the conflict issue. Thus, I stated this is the reason why I would like v4 beta because of avoiding this conflict issue. Remember now?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Andi Dittrich notifications@github.com Sent: Wednesday, February 19, 2020 5:27:59 PM To: EnlighterJS/Plugin.TinyMCE Plugin.TinyMCE@noreply.github.com Cc: ajtruckle truckleaj-software@hotmail.co.uk; State change state_change@noreply.github.com Subject: Re: [EnlighterJS/Plugin.TinyMCE] Feature request - Hide the Theme label and drop-down list (#6)

i can't follow you - mouseover on the current line is fully supported in EnlighterJS v2 and implemented by all official themes - see https://enlighterjs.org/Theme.Droide.htmlhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fenlighterjs.org%2FTheme.Droide.html&data=02%7C01%7C%7Cd732f8ca07954a3f1fc008d7b561115f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637177300807447238&sdata=nBtE%2F6nXxwU9aB7hhCLlyYmcZAXrs%2FZNiyV0CpW%2BuK4%3D&reserved=0

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEnlighterJS%2FPlugin.TinyMCE%2Fissues%2F6%3Femail_source%3Dnotifications%26email_token%3DAB45RM53ETVCZMPD6UJRKPDRDVTZ7A5CNFSM4KXVJARKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMIWHTA%23issuecomment-588342220&data=02%7C01%7C%7Cd732f8ca07954a3f1fc008d7b561115f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637177300807457246&sdata=vwNB2xasxONKqqEwJqxPez3aT1M6fX9K3o%2F8zls8mo8%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB45RM3QKYACQYPZLHSXINDRDVTZ7ANCNFSM4KXVJARA&data=02%7C01%7C%7Cd732f8ca07954a3f1fc008d7b561115f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637177300807467250&sdata=2jUL54XQVXwvWVldS0wPixaiZZUD8DkCrT7TNI2Ry7o%3D&reserved=0.

AndiDittrich commented 4 years ago

i know but you can still override the bbPress styles or fix them. it's not an issue with the plugin itself...

ajtruckle commented 4 years ago

I don’t know what affect overriding those styles will have. I do t want to fight the system.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Andi Dittrich notifications@github.com Sent: Wednesday, February 19, 2020 8:43:19 PM To: EnlighterJS/Plugin.TinyMCE Plugin.TinyMCE@noreply.github.com Cc: ajtruckle truckleaj-software@hotmail.co.uk; State change state_change@noreply.github.com Subject: Re: [EnlighterJS/Plugin.TinyMCE] Feature request - Hide the Theme label and drop-down list (#6)

i know but you can still override the bbPress styles or fix them

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEnlighterJS%2FPlugin.TinyMCE%2Fissues%2F6%3Femail_source%3Dnotifications%26email_token%3DAB45RM6IPJXSAV5CYV7HYU3RDWKWPA5CNFSM4KXVJARKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJPQHQ%23issuecomment-588445726&data=02%7C01%7C%7C45fe79f939f047aa343a08d7b57c5b37%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637177418011087875&sdata=uMqNqjC0ZnEOCCnYb4S8fjK%2BpgBwkQ2bgXVk%2BK3wbM0%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB45RM3UC73MLKR7EEJZ3ETRDWKWPANCNFSM4KXVJARA&data=02%7C01%7C%7C45fe79f939f047aa343a08d7b57c5b37%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637177418011097860&sdata=gXwWVR%2FeDxRBT5L%2F8URKdNWsCjyIorUGL6z8M4LVeXc%3D&reserved=0.