search

Ennea / warp-journal

Honkai: Star Rail gacha tracker and analysis.
MIT License
8 stars 4 forks source link

Fix/document windows installer process #17

Open technizor opened 2 weeks ago

technizor commented 2 weeks ago

Code changes to make the project compatible with Windows exe export again:

Should help with #13, but I don't know how the CI can be set up in this repository. For now, I left instructions.

technizor commented 2 weeks ago

Probably want to review / merge the parent PR first #16, I couldn't be bothered to rebase this one because without including #16 would break functionality according to my local testing. #16 was obsoleted by #18 being submitted with better changes.

FichteFoll commented 1 week ago

Thanks for taking a look at this. Unfortunately, it will take me a bit more time to review and test this than the other PR since I need to boot onto Windows and configure a semi-usable dev environment there until I can eventually start testing things, but I do want to take a look at it eventually. It may take me a few weeks, however.

technizor commented 1 week ago

Thanks for taking a look at this. Unfortunately, it will take me a bit more time to review and test this than the other PR since I need to boot onto Windows and configure a semi-usable dev environment there until I can eventually start testing things, but I do want to take a look at it eventually. It may take me a few weeks, however.

No worries. If needed, the relative module imports (from within warp-journal) are definitely a problem with nuitka as far as my testing goes, but refactoring those imports could be easily tested separately and merged first while the installer-specific stuff waits.

The installed version on my computer works so I don't need the changes merged urgently. Would be good to fix it for any other Windows users, but this is still only partway to a solution since there's no automation for generating these.

FichteFoll commented 6 days ago

Indeed, but once we have reliable steps that work on an actual Windows machine it would be much easier to port that into a CI/CD solution.

technizor commented 3 days ago

Rebased onto your changes.

Since it looks like you removed the only Dict union operator usage, I believe the Python version doesn't need to be bumped to 3.9 anymore.

The only Python code changes here are changing the local imports from within the warp_journal module to absolute imports due to nuitka.