search

Ennea / warp-journal

Honkai: Star Rail gacha tracker and analysis.
MIT License
8 stars 4 forks source link

Better compatibility with custom game paths #2

Closed jericjan closed 11 months ago

jericjan commented 1 year ago

I installed the game using neon-nyan's Collapse launcher. It installed the game for me without having the "Game" folder so a line in Player.log looks like this: Loading player data from F:/HSR/StarRail_Data/data.unity3d

So I modified the regex so that it would also detect this. It should still work even if you do have the "Game" folder in the path.

Ennea commented 1 year ago

util.py changed in #1, so this needs updating. If you could also adjust the GAME_PATH path in the Linux instructions in the readme, that would be great.

FichteFoll commented 1 year ago

I also made this change as a part of https://github.com/FichteForks/warp-journal/commit/baac8c104b359dab70db55589ebf3562e9fb4e2d, which I was waiting on #1 to be merged before I filed a PR for it.

FichteFoll commented 1 year ago

Does the Collapse launcher have a way of finding/identifying its install location and/or the install location of HSR? That way we could add automatic detection for it.

jericjan commented 1 year ago

Well, there is a file in %USERPROFILE%\AppData\LocalLow\CollapseLauncher\GameFolder\SRGlb\config.ini which contains game_install_path=F:/HSR for me. Why bother with this though? Won't the regex filter work fine regardless?

FichteFoll commented 1 year ago

Ah right, it already reads the game path from the logs in %USERPROFILE%, so never mind.