search

Ennea / warp-journal

Honkai: Star Rail gacha tracker and analysis.
MIT License
8 stars 4 forks source link

Convert colors to use `hsl`/`hsla` #4

Closed FichteFoll closed 1 year ago

FichteFoll commented 1 year ago

It's more convenient to modify these and they feel more natural to the human mind.

Numbers were slightly rounded after conversion for convenience with barely noticeable changes.

I know you disagreed on this change, so I made sure to do this in its own PR.

Ennea commented 1 year ago

Yea, I'm closing this one. Rounding colors is heresy 😋 They also don't need to be readable or intuitively understandable either.

FichteFoll commented 1 year ago

Rounding colors is heresy

Got any sources on how that actually affects things or is it just out of principle?

Ennea commented 1 year ago

It's just principle. I picked those colors in LCH color space. They're represented in sRGB space in the stylesheet because that's the "default" and they don't need to be readable anyway, as I said, since they aren't code. Converting them to HSL and then rounding them just seems nonsensical.

FichteFoll commented 1 year ago

Why not use lch() directly, then?

Ennea commented 1 year ago

Support for that is still a tad too recent for my taste.