search

Ennea / wishing-well

Genshin Impact wish history backup and analysis.
MIT License
17 stars 4 forks source link

Add alternative way to get install path #2

Closed TheProJeckt closed 2 years ago

TheProJeckt commented 2 years ago

moving the install location by hand breaks the registry entry, this commit fixes wishing well for users with this issue by getting the install location from a running genshin process.

this adds the dependency "psutil".

Ennea commented 2 years ago

I appreciate the PR, but I'm not going to merge it. First, I would rather not add more third party dependencies if it can be avoided. Also, I feel like manually moving the game someplace else is not something people usually do. I suppose I could consider pulling the location from the game's log file instead, like paimon.moe does it. But I think pulling it from the registry is fine.