Ennowulff / axage

ABAP teXt Adventure Game Engine
Apache License 2.0
19 stars 9 forks source link

Example of Axage with ABAP2UI5 #6

Open jung-thomas opened 1 year ago

jung-thomas commented 1 year ago

Using the new version in the Pull Request (that has ABAP Cloud Class based approach and serializable instances), I've created a stateless, UI5 version of the of the game interface using the other open-source project ABAP2UI5. I didn't want to do a pull request directly here so as not to introduce a direct, hard dependency to ABAP2UI5.

https://github.com/jung-thomas/axage_example

What the UI looks like. Basic but workable: image

Ennowulff commented 1 year ago

Hey @jung-thomas ! This is really cool! I❤️ it! Will ASAP investigate how you did it. Cheers Enno

Ennowulff commented 1 year ago

When pulling your repo, I get the message: Object type HTTP is not supported by this system

How could you export this? HTTP is not supported by abapGit!? https://docs.abapgit.org/ref-supported.html

jung-thomas commented 1 year ago

I didn't expect to be in there either as I didn't think it was supported by ABAPGit. I just used the abapGit plug-in in Eclipse. The Staging view included the HTTP service and pushed it to Git. Something in the Eclipse plug-in that isn't even supported by ABAPGit itself?

Try importing that repo again. I've cleaned everything out except the package and the ABAP2UI5 app class.

Ennowulff commented 1 year ago

everything is okay now, but now the main things are missing, aren't they? image

Method Z2UI5_IF_APP~MAIN
Method "Z2UI5_IF_APP~MAIN" is not declared or inherited in class "ZCL_AXAGE_DEMO1_UI". -
Public Section ZCL_AXAGE_DEMO1_UI
Implementation missing for method "Z2UI5_IF_APP~CONTROLLER". "Z2UI5_IF_APP~CONTROLLER".
jung-thomas commented 1 year ago

No. Everything seems to be there. It should just be one class that gets imported: image

I went to a fresh ABAP system and it imports from Git successfully. It also activates fine. image

The method ~main implementation is definitely in the class: https://github.com/jung-thomas/axage_example/blob/main/src/zcl_axage_demo1_ui.clas.abap#L24

When do you get that error? Upon activation? If so what does your inactive version of zcl_axage_demo1_ui look like?

Ennowulff commented 1 year ago

Sorry, I was confused about how to use abap2ui5... 😿

So now, when I start the abap2ui5-service and "link to the service" image

I get this error: Method call failed: Method Z2UI5_IF_APP~CONTROLLER of class ZCL_AXAGE_DEMO1_UI is not implemented.

Ennowulff commented 1 year ago

The same old story... 😢 I haven't updated abap2ui5 to the latest release... Now it works! Thanks again for this cool idea!