search

Enny1991 / PLSTM

137 stars 31 forks source link

multiPLSTM and RNN doesn't parameterize the cell correctly #8

Closed aht closed 7 years ago

aht commented 7 years ago

multiPLSTM and RNN doesn't parameterize the cell correctly.

multiPLSTM basically hardcode to cell = PhasedLSTMCell(units_p_layer, use_peepholes=True, state_is_tuple=True) so the params such as r_on, tau_init cannot be passed in.

Also in simplePhasedLSTM.py, the RNN function always creates PLSTM cell, not LSTM or GRU. This means that the run flag is not used flags.DEFINE_string("unit", "PLSTM", "Can be PSLTM, LSTM, GRU").

I'm happy to contribute a fix.

Enny1991 commented 7 years ago

@aht Thanks for the tip. Now the function accepts a list of cells such that you can parameterize them.

    outputs = multiPLSTM(cells, inputs, lens, n_input, initial_states)

I deleted the flags for the units. For a unit test it does not make sense to have them. The code shows only PLSTM.

+Enea

Enny1991 commented 7 years ago

solved, I close it