search

EnoPM / BetterOtherRoles

Among Us mod based on TheOtherRoles with more roles & better Among Us experience
GNU General Public License v3.0
13 stars 5 forks source link

[Bug Report] #1

Closed dabao40 closed 11 months ago

dabao40 commented 1 year ago

Describe the bug Undertaker can still kill other players even if the former is dragging a body

To Reproduce Steps to reproduce the behavior:

  1. I'm using local Among Us to test out Undertaker and see how it works for BetterOtherRoles and to test it out also for my mod, which is licensed under GPL-3.0
  2. Kill anyone who is not the Jackal and drag the dead body
  3. See error

Expected behavior The Kill button should not work and if the Undertaker tries to click the button nothing should happen.

Screenshots image

System (please complete the following information):

dabao40 commented 1 year ago

It is recommended to add the set target thingy in the ImpostorSetTarget function which is situated in PlayerControlPatch.cs instead of adding some random lines in UpdatePatch.cs that may cause the Undertaker to break.
Using the Palette.DisabledClear may cause the some severe problems. Please Delete the line and add the following line in PlayerControlPatch.cs if you have seen this review.
image This is located in the function called "impostorSetTarget"

EnoPM commented 11 months ago

I've changed that. Thanks you.