search

EnormousCloud / api3-dao-tracker

API3 DAO Tracker
https://enormous.cloud/dao/api3/tracker/
MIT License
3 stars 1 forks source link

Wrong gas spent in Wallets #12

Closed salgozino closed 2 years ago

salgozino commented 2 years ago

I would like to start thanking you for this dashboard! it's a great tool!.

I've noticed that In the wallets sections says for example: Spent 0.37889 ETH in fees, Est $1272.61, but I think that this data has a mistake. The amount in ETH is wrong and missing a few leading zeros.

I think that there is 2 leading zeros missed. It's not 0.37, should be 0.0037 eth. The USD price it's ok or very similar to what etherscan reports, at least for my staking transaction.

EnormousCloud commented 2 years ago

well, I wish that was just a mistake...

I believe you are quoting Burak's wallet statistics, as he is the only one with such expense for being active in the DAO. He literally spent more than a thousand dollars just on Ethereum fees, and this is around 0.37ETH. No zeros were missing, it is real... He is just the most active and we found no bug in rendering this. Just a crazy expense which is hard to believe. And its one of the reasons it is being displayed there.

When you are looking at the wallet list you see the summary on how much it was spent on the gas in total, and it accumulates history of all transactions fees that were made by the wallet: voting, delegations or any other DAO events.

salgozino commented 2 years ago

Well I has to be honest and I pick a random wallet from the list to not dox myself. But in my case I have only one txs to stake the API3, and shows like 0.4 eth in gas fees when I spent ~0.004eth. Maybe the random wallet that pick wasn't the best example.

I've found an example (just a random one, I do not know this wallet). https://enormous.cloud/dao/api3/tracker/wallets/0xf03f7c98a6e29f5367044fcacadf85a4fd8dc08d

This wallet has 1 staking event too, spending (according to the site): Gas Used: 133989, Gas Price: 37 GWei, Est $16.07. This translates as 4957593 GWei = 0.004957593 ETH, but in the wallets section shows as 0.49eth image

hope this help to find the bug. I'm guessing that it's just a UI mistake when formating the ETH value.

EnormousCloud commented 2 years ago

Thanks for the details, you are totally right, this example illustrates the issue much better.

Whatever this is, we will fix it.

EnormousCloud commented 2 years ago

The fix is live.