search

EnotYoyo / pysphero

Unofficial Sphero V2 api for bluetooth low energy toys
MIT License
42 stars 16 forks source link

Adding LMQ support #11

Closed MatP-MatP closed 4 years ago

MatP-MatP commented 4 years ago

Hi @EnotYoyo,

Found you project quite interesting. I would like to participate on it to add LightningMcQueen support. If you agree I can push my first branch. I am not an expert in Python, dev might be slow as I am also sniffing BT packets to find missing command. If you do not, no pb, I’ll fork.

Thanks for what you've done

EnotYoyo commented 4 years ago

Hi! Yes. You can create pull request, I'll review and merge it.

MatP-MatP commented 4 years ago

Cool!

Try to push my branch, but I cannot. I guess you need to add me somehow.

remote: Permission to EnotYoyo/pysphero.git denied to MatP-MatP. fatal: unable to access 'https://github.com/EnotYoyo/pysphero.git/': The requested URL returned error: 403

EnotYoyo commented 4 years ago

You must fork the repository. After, create some changes, push it into your repository and create pull request to my repository. It's detailed here and here

MatP-MatP commented 4 years ago

Thanks, not familiar with open projects. Did my first PR.

EnotYoyo commented 4 years ago

I close this.