ojalaquellueva
commented
8 months ago Proposed solution
I'm now thinking that there is nothing wrong with how the match threshold is being applied. The user should be able to apply a minimum acceptable threshold for fuzzy match scores. The threshold should apply to all matches, not just the best match. Also, the user should be able to filter higher taxonomic matches by match threshold in the same way. If the user wants to see all possible matches, they can always lower the match threshold.
The only problem here is the complete loss of a name from the display and from the download when there is no best match. A result should always be displayed for every name submitted. If no match with Overall_score>=match_threshold is found for a submitted name, then that name should be displayed followed by "[No match found]" in the Name_matched column, and all subsequent fields (to the right) blank. This result for this name should be the same in the Details display and in the download.
In summary:
- For every name submitted, there should be a name displayed in the results grid and the Details popup.
- In the download:
- If "Best Matches Only" is selected, then there should be exactly as many names in the download file as names submitted
- If "All Matches" is selected, then there should be at least one name in the download for every name submitted.
- In both cases (i.e., including "All Matches") only names above the match threshold should be included in the download file.
- If any submitted name does not return a match, it must still appear in the results display, the Details popup, and the download file, with "[No match found]" in column Name_matched, and all remaining columns blank.
- This behavior should be the same for "Sort by Overall Score" and "Sort by Higher Taxonomy"
Submiited name "Helotiaceae Diplothrix juniperifolia" is flagged in left-most column of results display as having "Better higher taxonomic match available". However, when the "Best match setting" is changed to "Higher taxonomy", the name disappears entirely. Furthermore, downloading "All matches" returns only one record. Names flagged in this way should always return at least two rows: one for the best overall score match, and a second result for the best higher taxonomic match.