search

Enriath / external-plugins

Where my external plugin code lives. Check the branches!
BSD 2-Clause "Simplified" License
19 stars 17 forks source link

[Plank Sack] Fix Mahogany Homes Not Counting Planks #125

Closed kramerology closed 1 month ago

kramerology commented 2 months ago

Fixes #124

Originally, counting planks for Mahogany Homes used the same code as regular construction to extract build costs from the build interface. The recent game update removed this interface for Mahogany Homes so this method was no longer possible.

The plugin already had code to support building a limited number of interface-less items (eg. hat rack) with an assumed cost of 1 plank.

This PR expands that system for all Mahogany Home build hotspots with hardcoded build costs.

Open to suggestions for improvements

PeepeePrince commented 2 months ago

Hello, has this been fixed? My plank sack is still not updating the amount of planks in the sack. Only updates the amount when I "check" it.

kramerology commented 2 months ago

This pull request should fix it but it hasn't been merged in to the actual plugin yet. Just waiting for it to be reviewed/accepted

RareSecond commented 2 months ago

@Enriath Just tagging you here to see if you can merge/approve it

PinkyOSRS commented 1 month ago

I'm new to all of this. hopw long does it usually take to get changes like this reviewed/accepted? I assume someone of the runelite team or jagex has to approve changes to keep the plugins safe? or is it just the original plugin author that has to accept the changes?

TheAngryUIM commented 1 month ago

@Enriath If you could try fixing this/merge that would be sweet