Enriath
commented
2 months ago This is a limitation of how the system is currently implemented. All that matters is the white text on an entry, in this case, Check. It doesn't matter where or what it is, Check maps to the hunter icon.
The original goal of this plugin was to mirror how RSHD & RS3's contextual cursor system worked. I want to say that at the time of development the official system worked in the same way, where words mapped to icons without context. Annoyingly I can't confirm this due to RS3 changing nearly every item's Check option to one of Check charges, Check-charges, or Check durability. I have memories of confirming it elsewhere, as this is not the first time unfitting icons have come up, and part of me wonders if the check renaming in RS3 is another confirmation of that, since the unique name would allow them to have a special icon if they wanted.
I fear that adding such override capabilities would require a decently sized rewrite to do it properly, and checking some edge cases would not be possible for me at the current time. It had been something I planned to do a long while ago, but never found the motivation for before the burnout. Part of the issue I foresee is making the changes low or zero maintenance; something I strive for with all my plugins is not having to update my code with each new content release. If I had to whitelist every door for Door Kicker, for example, it would be a miserable experience to document every door whenever Jagex adds or updates an area. The goal for this is so that, no matter what I'm up to, whether I'm actively playing or away from the game, the plugins I make can be used by others and enjoyed without issue. Of course, backend changes force me to fix stuff as needed, and given my current state it's a struggle to do anything at times (see Plank Sack, where I'm struggling to find motivation to even just do a code review for a major fix). A naive approach here would be to whitelist specific items to have a different check icon, which would fall into that same issue. Another approach would be to have it not apply to items in this case, but that still leaves the myriad other incorrect icons where Jagex reused the same action wording. I do not doubt there is a convenient and performant way to solve the problem, but finding the motivation to figure that out is beyond my burnt out brain, let alone implementing it and testing it.
I guess that herb sack has to be pretty big, since you've got to hunt around inside it to see how many herbs you have. Joking aside, I don't see this changing any time soon, though I could be hit with an urge to rewrite the parts of the code that need it. If Jagex wanted to add parity to RS3 and change those items to use Check charges, then it would solve it pretty easily, but I think we can both agree that they won't do that, and they also likely shouldn't.
This issue is for the external plugin: Contextual Cursor Plugin version: 1.3.1
On various items, the Hunter icon is being displayed when hovering the 'Check' option on the following items:
I think it should be changed to a different icon that resembles that option for these items or revert to the default icon. Probably for other items too, but these are the items i know that have that option.