EnricoMi / publish-unit-test-result-action

GitHub Action to publish unit test results on GitHub
Apache License 2.0
615 stars 184 forks source link

Option fail_on is not respected #618

Closed LorenzoBettini closed 2 months ago

LorenzoBettini commented 2 months ago

I specified fail_on: nothing in our workflow (due to flakes not currently handled) but the action still marks the PR as failed.

See https://github.com/eclipse/xtext/pull/3164

Am I missing something?

EnricoMi commented 2 months ago

https://github.com/eclipse/xtext/pull/3164#issuecomment-2301171013

LorenzoBettini commented 2 months ago

@EnricoMi sorry I forgot to close this myself. After merging the test results job does not fail.

Of course, that's a temporary workaround, waiting for flaky tests to be officially supported ;)